Skip to content

Commit 2c8b96b

Browse files
authored
Fix benchmarks not running on PRs (#1731)
Address an issue introduced in #1722 where benchmark workflows would not run on PRs (enabled when setting the "performance" label). ### Does this change impact existing behavior? No, CI only. ### Does this change need a changelog entry? Does it require a version change? No. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
1 parent ffd1cca commit 2c8b96b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/bench_pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66

77
permissions:
88
id-token: write
9-
contents: read
9+
contents: write # required by bench.yml and bench_s3express.yml even if we don't actually publish the results to gh-pages for PRs
1010

1111
jobs:
1212
integration:

0 commit comments

Comments
 (0)