Skip to content

Commit 19d12b8

Browse files
committed
fix(config): add explicit dict[str, Any] type to config in init_command_handler
1 parent bd44cfa commit 19d12b8

3 files changed

Lines changed: 10 additions & 12 deletions

File tree

src/orb/interface/init_command_handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ def _write_config_file(
692692
if default_provider_name:
693693
provider_section["default_provider_instance"] = default_provider_name
694694

695-
config = {
695+
config: dict[str, Any] = {
696696
"scheduler": {"type": user_config["scheduler_type"]},
697697
"provider": provider_section,
698698
}

src/orb/providers/aws/infrastructure/launch_template/manager.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,9 @@ def _handle_existing_lt_with_overrides(
364364
self, aws_template: AWSTemplate, request: Request
365365
) -> LaunchTemplateResult:
366366
"""Create a new LT version with overrides; handle failure per config."""
367-
override_fields = [f for f in _OVERRIDE_FIELDS if getattr(aws_template, f, None) is not None]
367+
override_fields = [
368+
f for f in _OVERRIDE_FIELDS if getattr(aws_template, f, None) is not None
369+
]
368370
self._logger.info(
369371
"Applying overrides %s to existing launch template %s",
370372
override_fields,

tests/onmoto/test_launch_template_existing.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -852,12 +852,12 @@ def test_on_update_failure_fail_explicit_config_present(self, moto_aws, moto_vpc
852852
)
853853

854854
# Simulate an UnauthorizedOperation ClientError from create_launch_template_version
855-
error_response = {
856-
"Error": {"Code": "UnauthorizedOperation", "Message": "not authorized"}
857-
}
855+
error_response = {"Error": {"Code": "UnauthorizedOperation", "Message": "not authorized"}}
858856

859857
def _boom(aws_template, request):
860-
raise BotoCE(error_response=error_response, operation_name="CreateLaunchTemplateVersion")
858+
raise BotoCE(
859+
error_response=error_response, operation_name="CreateLaunchTemplateVersion"
860+
)
861861

862862
manager._create_new_lt_version = _boom
863863

@@ -899,9 +899,7 @@ def test_on_tag_failure_fail_on_version_path(self, moto_aws, moto_vpc_resources)
899899
# Patch create_tags to raise AccessDenied
900900
error_response = {"Error": {"Code": "AccessDenied", "Message": "access denied"}}
901901
aws_client.ec2_client.create_tags = MagicMock(
902-
side_effect=BotoCE(
903-
error_response=error_response, operation_name="CreateTags"
904-
)
902+
side_effect=BotoCE(error_response=error_response, operation_name="CreateTags")
905903
)
906904

907905
with pytest.raises(Exception):
@@ -942,9 +940,7 @@ def test_on_tag_failure_warn_on_version_path(self, moto_aws, moto_vpc_resources)
942940
# Patch create_tags to raise AccessDenied
943941
error_response = {"Error": {"Code": "AccessDenied", "Message": "access denied"}}
944942
aws_client.ec2_client.create_tags = MagicMock(
945-
side_effect=BotoCE(
946-
error_response=error_response, operation_name="CreateTags"
947-
)
943+
side_effect=BotoCE(error_response=error_response, operation_name="CreateTags")
948944
)
949945

950946
result = manager.create_or_update_launch_template(template, _make_request())

0 commit comments

Comments
 (0)