Merge pull request #180 from awslabs/chore/dead-code-and-print-cleanup

chore: remove dead application/base files and replace bare print() calls

Author: fgogolli

.github/pull_request_template.md

@@ -71,3 +71,4 @@ Fixes #
 
 ## Reviewers
 <!-- @ mention specific team members who should review this -->
+@awslabs/orb-maintainers

src/orb/application/base/__init__.py

@@ -8,16 +8,10 @@
     PaginatedResponse,
 )
 
-from .commands import CommandBus, CommandHandler
-from .queries import QueryBus
-
 __all__: list[str] = [
     "BaseCommand",
     "BaseDTO",
     "BaseQuery",
     "BaseResponse",
-    "CommandBus",
-    "CommandHandler",
     "PaginatedResponse",
-    "QueryBus",
 ]

src/orb/application/base/commands.py

@@ -17,9 +17,9 @@
 set_container_factory(register_all_services)
 
 # Import configuration
-from orb.config.schemas.app_schema import AppConfig
-
 # Import logging
+from orb.cli.console import print_console
+from orb.config.schemas.app_schema import AppConfig
 from orb.infrastructure.logging.logger import get_logger, setup_logging
 
 
@@ -403,7 +403,7 @@ async def main() -> None:
     config_path = os.getenv("ORB_CONFIG_FILE")
 
     # Only print before app creation - no logger available yet
-    print("Starting Open Host Factory...")
+    print_console("Starting Open Host Factory...")
 
     try:
         async with await create_application(config_path) as app:
@@ -431,7 +431,7 @@ async def main() -> None:
 
     except Exception as e:
         # Keep print here - app creation failed, no logger available
-        print(f"Application failed: {e}")
+        print_console(f"Application failed: {e}")
         sys.exit(1)
 
 

src/orb/application/base/queries.py

@@ -109,6 +109,12 @@ def print_newline():
     _console.print()
 
 
+@_console_output
+def print_console(message: str):
+    """Print plain text message with no colour formatting."""
+    _console.print(message)
+
+
 def print_json(data: dict):
     """Print JSON data (always outputs, ignores LOG_CONSOLE_ENABLED)."""
     import json

src/orb/bootstrap/__init__.py

@@ -14,6 +14,7 @@
 
 # Re-export for backward compatibility
 from orb.cli.args import parse_args
+from orb.cli.console import print_error, print_info, print_success, print_warning
 from orb.cli.router import execute_command
 from orb.infrastructure.logging.logger import get_logger
 
@@ -69,7 +70,7 @@ async def main() -> None:
                     sys.argv = original_argv
 
             if error_output.strip():
-                print(error_output.strip(), file=sys.stderr)
+                print_error(error_output.strip())
             raise
 
         # Setup environment after arg parse — skip for init (it calls get_config_location() directly)
@@ -183,7 +184,7 @@ async def main() -> None:
                 if result.get("status") == "success":
                     sys.exit(0)
                 else:
-                    print(f"Error: {result.get('message')}", file=sys.stderr)
+                    print_error(f"Error: {result.get('message')}")
                     sys.exit(1)
             except Exception:
                 import traceback
@@ -227,9 +228,9 @@ async def main() -> None:
                 with open(args.output, "w") as f:
                     f.write(formatted_output)
                 if not args.quiet:
-                    print(f"Output written to {args.output}")
+                    print_success(f"Output written to {args.output}")
             else:
-                print(formatted_output)
+                print_info(formatted_output)
 
             if exit_code != 0:
                 sys.exit(exit_code)
@@ -252,7 +253,7 @@ async def main() -> None:
             error_output, exit_code = formatter.format_error(e, output_format)
 
             if not args.quiet:
-                print(error_output)
+                print_error(error_output)
             sys.exit(exit_code)
         finally:
             if scheduler_override_active:
@@ -267,10 +268,10 @@ async def main() -> None:
                     logger.warning("Failed to restore scheduler strategy: %s", e, exc_info=True)
 
     except KeyboardInterrupt:
-        print("\nOperation cancelled by user.")
+        print_warning("\nOperation cancelled by user.")
         sys.exit(130)
     except Exception as e:
-        print(f"Fatal error: {e}")
+        print_error(f"Fatal error: {e}")
         sys.exit(1)
 
 

src/orb/cli/console.py

@@ -18,9 +18,9 @@ class SDKMiddleware(ABC):
     Example:
         class LoggingMiddleware(SDKMiddleware):
             async def process(self, method_name, args, kwargs, next_handler):
-                print(f"Calling {method_name}")
+                logger.debug("Calling %s", method_name)
                 result = await next_handler(args, kwargs)
-                print(f"{method_name} returned: {result}")
+                logger.debug("%s returned: %s", method_name, result)
                 return result
     """