Merge pull request #157 from awslabs/fix/p1-bugfixes-wave1

fix: resolve except-pass antipatterns, DI duplicate registration, and pytest-asyncio config

Author: fgogolli

pytest.ini

@@ -4,6 +4,7 @@ norecursedirs = tests/onaws
 python_files = test_*.py
 python_classes = Test*
 python_functions = test_*
+asyncio_mode = strict
 addopts = --tb=short --strict-markers --disable-warnings
 markers =
     unit: Unit tests

src/orb/infrastructure/adapters/asg_query_adapter.py

@@ -1,7 +1,10 @@
 """Infrastructure adapter implementing ASGQueryPort via AWSClient."""
 
+import logging
 from typing import Any
 
+from botocore.exceptions import ClientError
+
 from orb.domain.base.ports.asg_query_port import ASGQueryPort
 
 
@@ -10,6 +13,7 @@ class ASGQueryAdapter(ASGQueryPort):
 
     def __init__(self, aws_client: Any) -> None:
         self._aws_client = aws_client
+        self._logger = logging.getLogger(__name__)
 
     async def get_asg_details(self, asg_name: str) -> dict[str, Any]:
         """Return current details for the named ASG, or an empty dict if not found."""
@@ -19,5 +23,11 @@ async def get_asg_details(self, asg_name: str) -> dict[str, Any]:
             )
             groups = response.get("AutoScalingGroups", [])
             return groups[0] if groups else {}
-        except Exception:
-            return {}
+        except ClientError as e:
+            if e.response["Error"]["Code"] in ("ValidationError",):
+                return {}
+            self._logger.warning("AWS API error querying ASG %s: %s", asg_name, e)
+            raise
+        except Exception as e:
+            self._logger.error("Unexpected error querying ASG %s: %s", asg_name, e)
+            raise

src/orb/infrastructure/di/port_registrations.py

@@ -5,10 +5,8 @@
     ConfigurationPort,
     ContainerPort,
     ErrorHandlingPort,
-    EventPublisherPort,
     ProviderConfigPort,
     ProviderSelectionPort,
-    SchedulerPort,
     TemplateConfigurationPort,
 )
 from orb.domain.base.ports.logging_port import LoggingPort
@@ -61,23 +59,6 @@ def create_unit_of_work_factory(c):
     container.register_singleton(ErrorHandlingAdapter, lambda c: ErrorHandlingAdapter())
     container.register_singleton(ErrorHandlingPort, lambda c: c.get(ErrorHandlingAdapter))
 
-    # Register template configuration manager with manual factory (handles
-    # optional dependencies)
-    def create_template_configuration_manager(c):
-        """Create template configuration manager with dependencies."""
-        return TemplateConfigurationManager(
-            config_manager=c.get(
-                ConfigurationManager
-            ),  # Use ConfigurationManager directly to break circular dependency
-            scheduler_strategy=c.get_optional(SchedulerPort),
-            logger=c.get(LoggingPort),
-            event_publisher=c.get_optional(EventPublisherPort),
-        )
-
-    container.register_singleton(
-        TemplateConfigurationManager, create_template_configuration_manager
-    )
-
     # Register template configuration port adapter
     from orb.infrastructure.adapters.template_configuration_adapter import (
         TemplateConfigurationAdapter,

src/orb/infrastructure/storage/json/strategy.py

@@ -355,8 +355,12 @@ def _save_data(self, entity_data: dict[str, dict[str, Any]]) -> None:
                     full_data = self.serializer.deserialize(content)
                 else:
                     full_data = {}
-            except Exception:
-                full_data = {}
+            except Exception as e:
+                self.logger.error(
+                    "Cannot read existing storage file before save, aborting to prevent data loss: %s",
+                    e,
+                )
+                raise
 
             # Ensure full_data is a dictionary
             if not isinstance(full_data, dict):

src/orb/providers/aws/infrastructure/aws_handler_factory.py

@@ -107,8 +107,10 @@ def create_handler(self, handler_type: str) -> AWSHandler:
                     native_spec_service=container.get(NativeSpecService),
                     config_port=config_port,
                 )
-            except Exception:
-                pass
+            except Exception as e:
+                self._logger.warning(
+                    "AWSNativeSpecService unavailable, native spec enrichment disabled: %s", e
+                )
 
         machine_adapter = AWSMachineAdapter(
             aws_client=self._aws_client,

src/orb/providers/aws/infrastructure/handlers/asg/handler.py

@@ -304,7 +304,10 @@ def detect_asg_instances(aws_client, instance_ids: list[str]) -> dict[str, list[
 
             return asg_mapping
 
-        except Exception:
+        except Exception as e:
+            logging.warning(
+                "Failed to detect ASG membership for instances, skipping capacity reduction: %s", e
+            )
             return {}
 
     def reduce_capacity_for_instance_ids(self, instance_ids: list[str]) -> None: