Merge pull request #150 from awslabs/refactor/dead-code-cleanup

refactor: delete dead code across 5 modules

Author: fgogolli

config/README.md

@@ -70,8 +70,7 @@ This section configures default values for VM templates:
     "company": "abc",
     "project": "awscloud",
     "team": "xyz"
-  },
-  "ssm_parameter_prefix": "/hostfactory/templates/"
+  }
 }
 ```
 
@@ -83,7 +82,6 @@ This section configures default values for VM templates:
 - `default_max_number`: Default maximum number of instances per template
 - `default_attributes`: Default attributes for templates (used by Host Factory)
 - `default_instance_tags`: Default tags to apply to instances
-- `ssm_parameter_prefix`: Prefix for SSM parameters containing template overrides
 
 ### Templates File
 
@@ -137,7 +135,7 @@ Example templates file:
 
 ### SSM Parameter Integration
 
-Templates can be overridden or extended using AWS SSM Parameters. The application will check for parameters with the prefix specified in `ssm_parameter_prefix` (default: `/hostfactory/templates/`).
+Templates can be overridden or extended using AWS SSM Parameters. The application will check for parameters under the `/hostfactory/templates/` path.
 
 For example, if you have a template with ID `OnDemand-Minimal-Template-VM`, you can override its properties by creating SSM parameters:
 

config/default_config.json

@@ -89,8 +89,7 @@
         "extensions": {
           "ami_resolution": {
             "enabled": true,
-            "fallback_on_failure": true,
-            "ssm_parameter_prefix": "/hostfactory/templates/"
+            "fallback_on_failure": true
           },
           "native_spec": {
             "spec_file_base_path": "config/specs/aws"

docs/root/api/multi-provider-api.md

@@ -94,7 +94,6 @@ export ORB_AWS_LAUNCH_TEMPLATE__CREATE_PER_REQUEST=false
     "aws_max_retries": {"type": "integer", "default": 3, "minimum": 0, "maximum": 10},
     "aws_read_timeout": {"type": "integer", "default": 30, "minimum": 1, "maximum": 300},
     "service_role_spot_fleet": {"type": "string", "default": "AWSServiceRoleForEC2SpotFleet"},
-    "ssm_parameter_prefix": {"type": "string", "default": "/hostfactory/templates/"},
     "handlers": {
       "type": "object",
       "properties": {

docs/root/deployment/dev_deployment_documentation.md

@@ -268,8 +268,7 @@ Note: symAinst-requestor.log is visible only if plugin successfully started and
           "region": "us-east-1",
           "profile": "default",
           "max_retries": 3,
-          "timeout": 30,
-          "ssm_parameter_prefix": "/hostfactory/templates/"
+          "timeout": 30
         }
       }
     ],

docs/root/user_guide/templates.md

@@ -317,13 +317,6 @@ aws ssm put-parameter \
   --name "/hostfactory/templates/my-template" \
   --type "String" \
   --value '{"template_id": "my-template", ...}'
-
-# Configure SSM prefix in config.json
-{
-  "template": {
-    "ssm_parameter_prefix": "/hostfactory/templates/"
-  }
-}
 ```
 
 ### Validating Templates

src/orb/application/ports/__init__.py

@@ -9,8 +9,6 @@
 from orb.application.ports.error_response_port import ErrorResponsePort
 from orb.application.ports.query_bus_port import QueryBusPort
 from orb.application.ports.registry_port import RegistryPort
-from orb.application.ports.scheduler_registry_port import SchedulerRegistryPort
-from orb.application.ports.storage_registry_port import StorageRegistryPort
 from orb.application.ports.template_dto_port import TemplateDTOPort
 
 __all__ = [
@@ -19,7 +17,5 @@
     "ErrorResponsePort",
     "QueryBusPort",
     "RegistryPort",
-    "SchedulerRegistryPort",
-    "StorageRegistryPort",
     "TemplateDTOPort",
 ]

src/orb/application/ports/scheduler_registry_port.py

@@ -2,33 +2,32 @@
 
 from typing import Any
 
-from orb.application.ports.scheduler_registry_port import SchedulerRegistryPort
 from orb.domain.base.ports.logging_port import LoggingPort
 
 
 class SchedulerRegistryService:
     """Application service interface for scheduler registry operations."""
 
-    def __init__(self, registry: SchedulerRegistryPort, logger: LoggingPort):
+    def __init__(self, registry: Any, logger: LoggingPort):
         self._registry = registry
         self._logger = logger
 
     def get_available_schedulers(self) -> list[str]:
         """Get list of available scheduler types."""
-        return self._registry.get_registered_types()  # type: ignore[attr-defined]
+        return self._registry.get_registered_types()
 
     def create_scheduler_strategy(self, scheduler_type: str, config: Any) -> Any:
         """Create scheduler strategy instance."""
-        return self._registry.create_strategy(scheduler_type, config)  # type: ignore[attr-defined]
+        return self._registry.create_strategy(scheduler_type, config)
 
     def is_scheduler_registered(self, scheduler_type: str) -> bool:
         """Check if scheduler type is registered."""
-        return self._registry.is_registered(scheduler_type)  # type: ignore[attr-defined]
+        return self._registry.is_registered(scheduler_type)
 
     def get_scheduler_capabilities(self, scheduler_type: str) -> dict[str, Any]:
         """Get scheduler capabilities (if supported)."""
         try:
-            strategy = self._registry.create_strategy(scheduler_type, {})  # type: ignore[attr-defined]
+            strategy = self._registry.create_strategy(scheduler_type, {})
             return getattr(strategy, "get_capabilities", lambda: {})()
         except Exception:
             return {}