fix: resolve actionlint and shellcheck issues

- Add validate-workflows job to CI pipeline
- Fix duplicate 'uses' fields in all workflow files
- Fix codecov action input parameter (file -> files)
- Fix shell script issues:
  * Replace problematic glob test with ls command
  * Fix exit code checks to use command directly
  * Fix quoting issues in user_data.sh
  * Remove unused INSTANCE_ID variable

Significantly reduces actionlint and shellcheck warnings while maintaining functionality.

Author: fgogolli

.github/workflows/ci.yml

@@ -25,7 +25,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Install yq
       uses: mikefarah/yq@master
@@ -76,6 +75,32 @@ jobs:
           make quality-check
         fi
 
+  validate-workflows:
+    name: Validate Workflows
+    runs-on: ubuntu-latest
+    needs: get-config
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v5
+
+    - name: Install yq
+      uses: mikefarah/yq@master
+
+    - name: Set up Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: ${{ needs.get-config.outputs.default-python-version }}
+
+    - name: Install UV
+      uses: astral-sh/setup-uv@v6
+      with:
+        enable-cache: true
+        cache-dependency-glob: "pyproject.toml.template"
+
+    - name: Validate workflows
+      run: make validate-all
+
   lint-black:
     name: Black (Code Formatting)
     runs-on: ubuntu-latest
@@ -84,7 +109,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -115,7 +139,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -146,7 +169,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -177,7 +199,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -209,7 +230,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -242,7 +262,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -274,7 +293,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -306,7 +324,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -338,7 +355,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -370,7 +386,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -408,7 +423,7 @@ jobs:
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v5
       with:
-        file: coverage-unit.xml
+        files: coverage-unit.xml
         flags: unit
         name: unit-tests
 
@@ -420,7 +435,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -458,7 +472,7 @@ jobs:
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v5
       with:
-        file: coverage-integration.xml
+        files: coverage-integration.xml
         flags: integration
         name: integration-tests
 
@@ -470,7 +484,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -512,7 +525,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -553,7 +565,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -596,7 +607,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Set up Python
       uses: actions/setup-python@v5
@@ -641,7 +651,7 @@ jobs:
       uses: codecov/codecov-action@v5
       if: always()
       with:
-        file: coverage-combined.xml
+        files: coverage-combined.xml
         flags: complete
         name: complete-tests
 

.github/workflows/container.yml

@@ -42,7 +42,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Install yq
       uses: mikefarah/yq@master
@@ -110,7 +109,6 @@ jobs:
 
     steps:
     - name: Checkout code
-      uses: actions/checkout@v5
       uses: actions/checkout@v5
       with:
         fetch-depth: 0

.github/workflows/dependabot.yml

@@ -17,7 +17,6 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v5
-      uses: actions/checkout@v5
 
     - name: Install yq
       uses: mikefarah/yq@master

awscpinst/config/user_data.sh

@@ -4,7 +4,7 @@
 set -e
 
 # Configure logging
-exec 1> >(logger -s -t $(basename $0)) 2>&1
+exec 1> >(logger -s -t "$(basename "$0")") 2>&1
 
 echo "[INFO] Starting instance configuration..."
 
@@ -110,9 +110,8 @@ systemctl start amazon-cloudwatch-agent
 echo "[INFO] Configuring instance..."
 
 # Set hostname
-INSTANCE_ID=$(curl -s http://169.254.169.254/latest/meta-data/instance-id)
 PRIVATE_IP=$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)
-hostnamectl set-hostname ${PRIVATE_IP}
+hostnamectl set-hostname "${PRIVATE_IP}"
 
 # Configure system limits
 echo "[INFO] Configuring system limits..."

dev-tools/scripts/container_build.sh

@@ -102,7 +102,7 @@ build_image() {
     log_info "Building Docker image..."
 
     # Build wheel first if it doesn't exist
-    if [[ ! -f "dist/"*.whl ]]; then
+    if ! ls dist/*.whl 1> /dev/null 2>&1; then
         log_info "Building wheel package..."
         make build || {
             log_error "Failed to build wheel package"

tests/test-docker.sh

@@ -137,9 +137,7 @@ test_container_startup() {
 
     # Test version command
     local version_output
-    version_output=$(docker run --rm "${TEST_IMAGE_NAME}" version 2>&1)
-
-    if [[ $? -ne 0 ]]; then
+    if ! version_output=$(docker run --rm "${TEST_IMAGE_NAME}" version 2>&1); then
         log_error "Container version command failed"
         log_error "Output: ${version_output}"
         return 1