Skip to content

Wrong parameter when creating vocabularies in sockeye.train.create_data_iters_and_vocabs #1113

@iPRET

Description

@iPRET

I think I found a bug in the sockeye.train.create_data_iters_and_vocabs function.

If I understand the code correctly, I suspect lines 388 and 390 should be:
source_factor_vocab_same_as_source=args.source_factors_use_source_vocab and
target_factor_vocab_same_as_target=args.target_factors_use_target_vocab,
rather than what they are now. (҂◡_◡)
image

Is that correct?
Thanks!
I.P.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions