backend: fix zero-numberio in dry-run #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In offline verification, io_hist_tree is not saved to the state file, so `io_u->numberio` is always zero in the second job (the verify phase). To address this, `do_dry_run()` simulates the saved WRITE job and logs io_u entries into io_hist_tree via `log_io_piece()`. The issue is that `io_u->numberio` is always zero when passed to log_io_piece(). To reproduce this issue, run the following jobs in turn. [test] name=writetest filename=/dev/nvme0n1 ioengine=io_uring direct=1 bs=512K iodepth=128 rw=randwrite runtime=20 time_based verify=crc32c verify_state_save=1 do_verify=0 [test] name=writetest filename=/dev/nvme0n1 ioengine=io_uring direct=1 bs=512K iodepth=128 rw=randwrite verify=crc32c verify_state_load=1 verify_only=1 verify_dump=1 Fixes: axboe#2013 Signed-off-by: Minwoo Im <[email protected]>
Collaborator
|
Thanks. In fio 3.40 the stopping criterion did not depend on the io_u's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In offline verification, io_hist_tree is not saved to the state file, so
io_u->numberiois always zero in the second job (the verify phase). To address this,do_dry_run()simulates the saved WRITE job and logs io_u entries into io_hist_tree vialog_io_piece(). The issue is thatio_u->numberiois always zero when passed to log_io_piece().To reproduce this issue, run the following jobs in turn.
Fixes: #2013