Fixes (#85)

* fixes

* changed some defaults in new work
* updated tests accordingly
* do not use land_binary_mask to plot in animation when plotting after the simulation has been run previously

* updated whats new

Author: kthyng

docs/whats_new.md

@@ -1,5 +1,11 @@
 # What's New
 
+## 2.4.2 (March 6, 2026)
+
+* changed some defaults in new work
+* updated tests accordingly
+* do not use land_binary_mask to plot in animation when plotting after the simulation has been run previously
+
 ## v2.4.0 (March 5, 2026)
 
 * Changed default value of `use_static_masks` to False from True, so that wet/dry masks from ocean models are used by default.

particle_tracking_manager/config_the_manager.py

@@ -232,8 +232,8 @@ def check_lon_lat_geojson_consistency(self) -> Self:
         """Check if lon and lat are set when geojson is None, and vice versa."""
         if self.geojson is None:
             if self.lon is None and self.lat is None:
-                self.lon = -151.0
-                self.lat = 58.0
+                self.lon = -152.6
+                self.lat = 59.3
                 logger.info(
                     "Using default lon and lat set to -151.0 and 58.0 respectively."
                 )

particle_tracking_manager/models/opendrift/config_opendrift.py

@@ -823,7 +823,7 @@ class LarvalFishModelConfig(OceanDriftModelConfig):
 
     # Egg hatching parameters
     hatching_method: HatchingMethodEnum = Field(
-        default=HatchingMethodEnum.temperature,
+        default=HatchingMethodEnum.fixed_time,
         description="Egg hatching method. temperature: use ambient temperature (Ellertsen et al. 1988). fixed_time: hatch after fixed duration.",
         title="Hatching Method",
         json_schema_extra={
@@ -941,7 +941,7 @@ class PhytoplanktonModelConfig(OceanDriftModelConfig):
 
     # Vertical behavior parameters
     vertical_behavior_mode: VerticalBehaviorModeEnum = Field(
-        default=VerticalBehaviorModeEnum.depth,
+        default=VerticalBehaviorModeEnum.dvm,
         description="Vertical behavior mode. none: passive. depth: maintain preferred depth band. dvm: diel vertical migration.",
         title="Vertical Behavior Mode",
         json_schema_extra={

particle_tracking_manager/models/opendrift/plot.py

@@ -170,7 +170,13 @@ def plot(plot_name, input_kwargs, o, filename, drift_model):
         # landmask is being used ("auto landmask")
         # if not using the global land mask, then plot the wetdry model
         # landmask with these special inputs to look best.
-        if o._config["general:use_auto_landmask"]["value"] == False:
+        # cannot plot land separate from simulation since then the reader
+        # is not available with the information. Checking for readers checks
+        # for that.
+        if (
+            o._config["general:use_auto_landmask"]["value"] == False
+            and len(o.env.readers.keys()) > 0
+        ):
             kwargs.update(
                 {
                     "background": "land_binary_mask",

tests/test_config_opendrift.py

@@ -270,7 +270,7 @@ def test_Phytoplankton_defaults():
         drift_model="Phytoplankton",
         steps=1,
     )
-    assert m.vertical_behavior_mode == VerticalBehaviorModeEnum.depth
+    assert m.vertical_behavior_mode == VerticalBehaviorModeEnum.dvm
     assert m.w_active == 0.001
     assert m.z_pref == -10.0
     assert m.do3D == True

tests/test_config_the_manager.py

@@ -135,8 +135,8 @@ def test_seed_location_inputs():
 
     m = TheManagerConfig(steps=1, start_time="2022-01-01", geojson=None)
     # these are set in a validator if geojson is None and lon/lat are None
-    assert m.lon == -151.0
-    assert m.lat == 58.0
+    assert m.lon == -152.6
+    assert m.lat == 59.3
 
     with pytest.raises(ValidationError):
         m = TheManagerConfig(