Skip to content

Commit d7cacea

Browse files
authored
Fix missing renaming #2602 (#2604)
* Fix missing renaming #2602 * Update docs/DevSetup.md
1 parent e7040f5 commit d7cacea

File tree

23 files changed

+110
-101
lines changed

23 files changed

+110
-101
lines changed

1k/build.profiles

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ guava=33.3.1
8585
# The emsdk version, as stable as possible
8686
# Notes:
8787
# - emscan-deps available since emsdk-4.0.3, but it's still not work properly
88-
# - since emsdk-4.0.0+ can't be debugging via chrome properly
88+
# - since emsdk-4.0.0+ can't be debugging via chrome properly on windows (macos and linux no this issue)
8989
# - axmol can build with emsdk-3.1.73+
9090
# - please use emsdk-3.1.73 if you want debug axmol wasm app properly
9191
emsdk=3.1.73+

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122

123123
- Update android devenv to support android 16 by @halx99 in https://github.com/axmolengine/axmol/pull/2546
124124
- Update Android Studio minimum required version to `2024.3.2`
125-
- **Downgrade emsdk from `4.0.6` to `3.1.73` due to axmol apps can't be debugging via chrome properly when build with emsdk-4.0+, the breakpoint can't be trigger by default, or triggerd, but can't watch any variables even through build with -O0**
125+
- **Downgrade emsdk from `4.0.6` to `3.1.73` due to axmol apps can't be debugging via chrome properly on windows when build with emsdk-4.0+, the debugger will always report `No debug information for function "<func_name_signature>"`, and can't watch any variables even through build with `-O0`**
126126

127127
## Bug fixes
128128

core/base/Director.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ void Director::setDefaultValues()
263263

264264
void Director::setGLDefaultValues()
265265
{
266-
// This method SHOULD be called only after glView_ was initialized
266+
// This method SHOULD be called only after _renderView was initialized
267267
AXASSERT(_renderView, "opengl view should not be null");
268268

269269
_renderer->setDepthTest(false);

core/platform/ios/DirectorCaller-ios.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ - (void)doCaller:(id)sender
139139
{
140140
ax::Director* director = ax::Director::getInstance();
141141
#if AX_GLES_PROFILE
142-
EAGLContext* context = [(EARenderView*)director->getRenderView()->getEARenderView() context];
142+
EAGLContext* context = [(__bridge EARenderView*)director->getRenderView()->getEARenderView() context];
143143
if (context != [EAGLContext currentContext])
144144
glFlush();
145145

core/platform/winrt/RenderViewImpl-winrt.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ THE SOFTWARE.
4444
namespace ax
4545
{
4646

47-
static RenderViewImpl* s_pEglView = nullptr;
47+
static RenderViewImpl* s_renderView = nullptr;
4848

4949
static EventMouse::MouseButton checkMouseButton(Windows::UI::Core::PointerEventArgs const& args)
5050
{
@@ -116,7 +116,7 @@ RenderViewImpl::RenderViewImpl()
116116
, m_appShouldExit(false)
117117
, _lastMouseButtonPressed(EventMouse::MouseButton::BUTTON_UNSET)
118118
{
119-
s_pEglView = this;
119+
s_renderView = this;
120120
_viewName = "axmol2";
121121
m_keyboard = KeyBoardWinRT();
122122

@@ -127,8 +127,8 @@ RenderViewImpl::RenderViewImpl()
127127

128128
RenderViewImpl::~RenderViewImpl()
129129
{
130-
AX_ASSERT(this == s_pEglView);
131-
s_pEglView = nullptr;
130+
AX_ASSERT(this == s_renderView);
131+
s_renderView = nullptr;
132132
}
133133

134134
bool RenderViewImpl::initWithRect(std::string_view viewName, const Rect& rect, float frameZoomFactor)
@@ -452,7 +452,7 @@ void RenderViewImpl::centerWindow()
452452

453453
RenderViewImpl* RenderViewImpl::sharedRenderView()
454454
{
455-
return s_pEglView;
455+
return s_renderView;
456456
}
457457

458458
int RenderViewImpl::Run()

core/renderer/Renderer.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -406,16 +406,15 @@ void Renderer::render()
406406
{
407407
// TODO: setup camera or MVP
408408
_isRendering = true;
409-
// if (_glViewAssigned)
409+
410+
// Process render commands
411+
// 1. Sort render commands based on ID
412+
for (auto&& renderqueue : _renderGroups)
410413
{
411-
// Process render commands
412-
// 1. Sort render commands based on ID
413-
for (auto&& renderqueue : _renderGroups)
414-
{
415-
renderqueue.sort();
416-
}
417-
visitRenderQueue(_renderGroups[0]);
414+
renderqueue.sort();
418415
}
416+
visitRenderQueue(_renderGroups[0]);
417+
419418
clean();
420419
_isRendering = false;
421420
}

core/ui/UIEditBox/UIEditBoxImpl-ios.mm

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,9 @@ of this software and associated documentation files (the "Software"), to deal
182182
void EditBoxImplIOS::updateNativeFrame(const Rect& rect)
183183
{
184184
auto renderView = ax::Director::getInstance()->getRenderView();
185-
EARenderView* eaglView = (EARenderView*)renderView->getEARenderView();
185+
EARenderView* eaView = (__bridge EARenderView*)renderView->getEARenderView();
186186

187-
float factor = eaglView.contentScaleFactor;
187+
float factor = eaView.contentScaleFactor;
188188

189189
[_systemControl updateFrame:CGRectMake(rect.origin.x / factor, rect.origin.y / factor, rect.size.width / factor,
190190
rect.size.height / factor)];
@@ -210,8 +210,8 @@ of this software and associated documentation files (the "Software"), to deal
210210
UIFont* EditBoxImplIOS::constructFont(const char* fontName, int fontSize)
211211
{
212212
AXASSERT(fontName != nullptr, "fontName can't be nullptr");
213-
EARenderView* eaglView = static_cast<EARenderView*>(ax::Director::getInstance()->getRenderView()->getEARenderView());
214-
float retinaFactor = eaglView.contentScaleFactor;
213+
auto eaView = static_cast<EARenderView*>(ax::Director::getInstance()->getRenderView()->getEARenderView());
214+
float retinaFactor = eaView.contentScaleFactor;
215215
NSString* fntName = [NSString stringWithUTF8String:fontName];
216216

217217
fntName = [[fntName lastPathComponent] stringByDeletingPathExtension];

core/ui/UIEditBox/UIEditBoxImpl-mac.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@ of this software and associated documentation files (the "Software"), to deal
195195

196196
void EditBoxImplMac::updateNativeFrame(const ax::Rect& rect)
197197
{
198-
RenderView* eglView = Director::getInstance()->getRenderView();
199-
auto frameSize = eglView->getFrameSize();
198+
RenderView* renderView = Director::getInstance()->getRenderView();
199+
auto frameSize = renderView->getFrameSize();
200200
// Coordinate System on OSX has its origin at the lower left corner.
201201
// https://developer.apple.com/library/ios/documentation/General/Conceptual/Devpedia-CocoaApp/CoordinateSystem.html
202202
auto screenPosY = frameSize.height - rect.origin.y - rect.size.height;

core/ui/UIEditBox/iOS/UIEditBoxIOS.mm

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -320,9 +320,9 @@ - (void)setPlaceHolder:(NSString*)text
320320
- (void)doAnimationWhenKeyboardMoveWithDuration:(float)duration distance:(float)distance
321321
{
322322
auto view = ax::Director::getInstance()->getRenderView();
323-
EARenderView* eaglView = (EARenderView*)view->getEARenderView();
323+
EARenderView* eaView = (__bridge EARenderView*)view->getEARenderView();
324324

325-
[eaglView doAnimationWhenKeyboardMoveWithDuration:duration distance:distance];
325+
[eaView doAnimationWhenKeyboardMoveWithDuration:duration distance:distance];
326326
}
327327

328328
- (void)updateFrame:(CGRect)rect
@@ -337,9 +337,9 @@ - (void)updateFrame:(CGRect)rect
337337
- (void)openKeyboard
338338
{
339339
auto view = ax::Director::getInstance()->getRenderView();
340-
EARenderView* eaglView = (EARenderView*)view->getEARenderView();
340+
EARenderView* eaView = (__bridge EARenderView*)view->getEARenderView();
341341

342-
[eaglView addSubview:self.textInput];
342+
[eaView addSubview:self.textInput];
343343
[self.textInput becomeFirstResponder];
344344
}
345345

@@ -362,9 +362,9 @@ - (BOOL)textFieldShouldReturn:(UITextField*)sender
362362
- (void)animationSelector
363363
{
364364
auto view = ax::Director::getInstance()->getRenderView();
365-
EARenderView* eaglView = (EARenderView*)view->getEARenderView();
365+
EARenderView* eaView = (__bridge EARenderView*)view->getEARenderView();
366366

367-
[eaglView doAnimationWhenAnotherEditBeClicked];
367+
[eaView doAnimationWhenAnotherEditBeClicked];
368368
}
369369

370370
#pragma mark - UITextView delegate methods
@@ -376,9 +376,9 @@ - (BOOL)textViewShouldBeginEditing:(UITextView*)textView
376376
_returnPressed = NO;
377377

378378
auto view = ax::Director::getInstance()->getRenderView();
379-
EARenderView* eaglView = (EARenderView*)view->getEARenderView();
379+
EARenderView* eaView = (__bridge EARenderView*)view->getEARenderView();
380380

381-
if ([eaglView isKeyboardShown])
381+
if ([eaView isKeyboardShown])
382382
{
383383
[self performSelector:@selector(animationSelector) withObject:nil afterDelay:0.0f];
384384
}
@@ -469,9 +469,9 @@ - (BOOL)textFieldShouldBeginEditing:(UITextField*)sender // return NO to disall
469469
_returnPressed = NO;
470470

471471
auto view = ax::Director::getInstance()->getRenderView();
472-
EARenderView* eaglView = (EARenderView*)view->getEARenderView();
472+
EARenderView* eaView = (__bridge EARenderView*)view->getEARenderView();
473473

474-
if ([eaglView isKeyboardShown])
474+
if ([eaView isKeyboardShown])
475475
{
476476
[self performSelector:@selector(animationSelector) withObject:nil afterDelay:0.0f];
477477
}

core/ui/UIWebView/UIWebViewImpl-ios.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,8 @@ - (void)setupWebView
133133
if (!self.wkWebView.superview)
134134
{
135135
auto view = ax::Director::getInstance()->getRenderView();
136-
auto eaglView = (EARenderView*)view->getEARenderView();
137-
[eaglView addSubview:self.wkWebView];
136+
auto eaView = (__bridge EARenderView*)view->getEARenderView();
137+
[eaView addSubview:self.wkWebView];
138138
}
139139
}
140140

0 commit comments

Comments
 (0)