chore: convert impossible cases to expect

Author: mistydemeo

cargo-dist/src/tasks.rs

@@ -1981,18 +1981,17 @@ impl<'pkg_graph> DistGraphBuilder<'pkg_graph> {
         }
         let release = self.release(to_release);
         let release_id = &release.id;
-        let Some(schema_release) = self.manifest.release_by_name(&release.app_name) else {
-            warn!("skipping shell installer: couldn't find the release");
-            return;
-        };
-        let Some(install_dir_env_var) = schema_release.install_dir_env_var.to_owned() else {
-            warn!("skipping shell installer: couldn't determine app-specific environment variable");
-            return;
-        };
-        let Some(download_url) = schema_release.artifact_download_url() else {
-            warn!("skipping shell installer: couldn't compute a URL to download artifacts from");
-            return;
-        };
+        let schema_release = self
+            .manifest
+            .release_by_name(&release.app_name)
+            .expect("couldn't find the release!?");
+        let install_dir_env_var = schema_release
+            .install_dir_env_var
+            .to_owned()
+            .expect("couldn't determine app-specific environment variable!?");
+        let download_url = schema_release
+            .artifact_download_url()
+            .expect("couldn't compute a URL to download artifacts from!?");
         let artifact_name = format!("{release_id}-installer.sh");
         let artifact_path = self.inner.dist_dir.join(&artifact_name);
         let installer_url = format!("{download_url}/{artifact_name}");
@@ -2064,14 +2063,11 @@ impl<'pkg_graph> DistGraphBuilder<'pkg_graph> {
         } else {
             &release.id
         };
-        let Some(download_url) = self
+        let download_url = self
             .manifest
             .release_by_name(&release.id)
             .and_then(|r| r.artifact_download_url())
-        else {
-            warn!("skipping Homebrew formula: couldn't compute a URL to download artifacts from");
-            return;
-        };
+            .expect("couldn't compute a URL to download artifacts from!?");
 
         let artifact_name = format!("{formula}.rb");
         let artifact_path = self.inner.dist_dir.join(&artifact_name);
@@ -2222,20 +2218,17 @@ impl<'pkg_graph> DistGraphBuilder<'pkg_graph> {
         // Get the basic info about the installer
         let release = self.release(to_release);
         let release_id = &release.id;
-        let Some(schema_release) = self.manifest.release_by_name(&release.app_name) else {
-            warn!("skipping powershell installer: couldn't find the release");
-            return;
-        };
-        let Some(install_dir_env_var) = schema_release.install_dir_env_var.to_owned() else {
-            warn!("skipping shell installer: couldn't determine app-specific environment variable");
-            return;
-        };
-        let Some(download_url) = schema_release.artifact_download_url() else {
-            warn!(
-                "skipping powershell installer: couldn't compute a URL to download artifacts from"
-            );
-            return;
-        };
+        let schema_release = self
+            .manifest
+            .release_by_name(&release.app_name)
+            .expect("couldn't find the release!?");
+        let install_dir_env_var = schema_release
+            .install_dir_env_var
+            .to_owned()
+            .expect("couldn't determine app-specific environment variable!?");
+        let download_url = schema_release
+            .artifact_download_url()
+            .expect("couldn't compute a URL to download artifacts from!?");
         let artifact_name = format!("{release_id}-installer.ps1");
         let artifact_path = self.inner.dist_dir.join(&artifact_name);
         let installer_url = format!("{download_url}/{artifact_name}");
@@ -2299,14 +2292,11 @@ impl<'pkg_graph> DistGraphBuilder<'pkg_graph> {
         }
         let release = self.release(to_release);
         let release_id = &release.id;
-        let Some(download_url) = self
+        let download_url = self
             .manifest
             .release_by_name(&release.app_name)
             .and_then(|r| r.artifact_download_url())
-        else {
-            warn!("skipping npm installer: couldn't compute a URL to download artifacts from");
-            return;
-        };
+            .expect("couldn't compute a URL to download artifacts from!?");
 
         let app_name = if let Some(name) = &release.npm_package {
             name.clone()