Skip to content

publish-prereleases = true only takes effect if publish jobs contains npm or homebrew #1744

Closed
astral-sh/cargo-dist
#33
@jackkleeman

Description

@jackkleeman

Currently the logic to determine if publish-prereleases = true makes it into the plan depends on the prerelease=true flag being set for both of the npm and homebrew v1 config blocks. If both of those are None, we default to false. However, its possible to have custom publish jobs which would also be skipped on prerelease. I feel that if both are None, we should still respect the value set in the dist config, if its set, before defaulting to false. I think this could be a breaking change, if there are custom publish jobs that users are expecting not to execute on prerelease.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions