Should 'history' store events based on tribeId and not civId

[axx0]

Partly related to this issue.
Currently the events in history (Engine/src/History/History.cs) are stored based on civId (0...7). Should we instead store events based on tribeId (0...21), so we account for e.g. dead civs?

public abstract class HistoryEvent
    {
        public HistoryEventType EventType { get; }
        public int Civ { get; }

        public int Turn { get; }
        protected HistoryEvent(HistoryEventType eventType, int civ, Game game)
        {
            EventType = eventType;
            Civ = civ;
            Turn = game.TurnNumber;
        }
    }

[hoodlm]

There are some other places in the codebase where we use raw ints, like https://github.com/axx0/Civ2-clone/blob/master/Model/Core/Advances/AdvanceResearch.cs#L7

If we want to standardize on TribeId to uniquely identify a civilization - would it be worthwhile to hunt all these down, replace any int civId with a wrapper TribeId class to avoid mixups between CivId and TribeId?

At the risk of philosophical controversy... standardizing on TribeId also leaves the door open for "big ideas" in the distant future, like the possibility of running more than 8 civs on the same game...

[axx0]

If we want to standardize on TribeId to uniquely identify a civilization - would it be worthwhile to hunt all these down, replace any int civId with a wrapper TribeId class to avoid mixups between CivId and TribeId?

I'm thinking do we really need civId? It's just a number we assign to civs at startup (0=barbs, 1...8 other civs), but it holds no tangible information (unlike tribeId, which points to rules.txt). Also what happens when a civ gets destroyed and another one pops up? Do you assign the dead civ's id (e.g. id=3) to the new civ? That's bound to mess things up when recording history.

Also I know we can already support 8 civs (when starting new game you should be able to select 8 civs). But to which civ in rules file does this civ point (there are 21 of them there)?

[reubene]

Not a bad idea, although even in a regular game tribes can come back so tribeId is not a fully unique identifier. It's certainly better than civId for history

[hoodlm]

although even in a regular game tribes can come back

interesting, we're off on a tangent here, but i'm curious what circumstances would cause this? civil war?

[reubene]

although even in a regular game tribes can come back

interesting, we're off on a tangent here, but i'm curious what circumstances would cause this? civil war?

So there are two ways, civil war being one the other is simply if the map is big enough and empty enough civ's can restart more than 3 times if they are eliminated before the restart cutoff date, I've seen a game with the Spanish popping up three times