fix: LSP start logic (#1504)

* Revert "fix: remove manual `LspStart`, close #1478. (#1479)"

This reverts commit 7dab4b9.

* Revert "fixup(#1466): load lsp config with proper event. (#1472)"

This reverts commit 53eeeec.

* fix: LSP start logic

This should acc fix #1472 and #1479 cuz iirc the root cause was that lspconfig
changed how `LspStart` works. Now it only starts one _specific_ server (passed
via the first argument), instead of starting all matching servers automatically.
So we gotta manually start all the servers that match the current filetype
instead.

Signed-off-by: Jint-lzxy <[email protected]>

* fix: redundant return

Signed-off-by: Jint-lzxy <[email protected]>

* fix: invoke `:LspStart` correctly

Signed-off-by: Jint-lzxy <[email protected]>

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: Jint-lzxy <[email protected]>

Author: ayamir

lua/modules/configs/completion/lsp.lua

@@ -18,4 +18,7 @@ return function()
 	end
 
 	pcall(require, "user.configs.lsp")
+
+	-- Start LSPs
+	pcall(vim.cmd.LspStart)
 end

lua/modules/configs/editor/persisted.lua

@@ -1,16 +1,4 @@
 return function()
-	vim.api.nvim_create_autocmd("User", {
-		pattern = "PersistedLoadPost",
-		desc = "Fix LSP/Highlighting on auto session restore",
-		callback = function()
-			local bufname = vim.api.nvim_buf_get_name(0)
-			if bufname and bufname ~= "" then
-				vim.defer_fn(function()
-					vim.cmd("edit")
-				end, 1)
-			end
-		end,
-	})
 	require("modules.utils").load_plugin("persisted", {
 		save_dir = vim.fn.expand(vim.fn.stdpath("data") .. "/sessions/"),
 		autostart = true,

lua/modules/plugins/completion.lua

@@ -2,7 +2,7 @@ local completion = {}
 
 completion["neovim/nvim-lspconfig"] = {
 	lazy = true,
-	event = { "BufReadPre", "BufNewFile" },
+	event = { "CursorHold", "CursorHoldI" },
 	config = require("completion.lsp"),
 	dependencies = {
 		{ "mason-org/mason.nvim" },