Merge pull request #19 from aybruhm/feat/add-bulk-delete-functionality-for-trades

[FEAT]: add bulk delete functionality for trades

Author: aybruhm

api/adapters/inbound/http/trade_routes.py

@@ -32,6 +32,10 @@ class TradeBody(BaseModel):
     asset_class: Optional[str] = None
 
 
+class BulkDeleteRequest(BaseModel):
+    trade_ids: list[UUID]
+
+
 def _body_to_request(body: TradeBody) -> CreateTradeRequest:
     return CreateTradeRequest(
         portfolio_id=body.portfolio_id,
@@ -148,6 +152,24 @@ async def delete_trade(
         raise HTTPException(status_code=400, detail=str(e))
 
 
+@router.post("/bulk/delete", status_code=status.HTTP_204_NO_CONTENT)
+async def bulk_delete_trades(
+    request: BulkDeleteRequest,
+    _: User = Depends(get_current_user),
+    session: AsyncSession = Depends(get_session),
+):
+    try:
+        interactor = TradeInteractor(session)
+        await interactor.delete_batch_trades(request.trade_ids)
+        await session.commit()
+    except ValueError as e:
+        await session.rollback()
+        raise HTTPException(status_code=400, detail=str(e))
+    except Exception as e:
+        await session.rollback()
+        raise HTTPException(status_code=400, detail=str(e))
+
+
 @router.post("/import/validate")
 async def validate_csv(
     file: UploadFile = File(...),

api/adapters/outbound/persistence/trade_repository.py

@@ -86,6 +86,17 @@ async def delete(self, trade_id: UUID) -> None:
             await self.session.delete(model)
             await self.session.flush()
 
+    async def delete_batch(self, trade_ids: List[UUID]) -> int:
+        result = await self.session.execute(
+            select(TradeModel).where(TradeModel.id.in_(trade_ids))
+        )
+        models = result.scalars().all()
+        deleted_count = len(models)
+        for model in models:
+            await self.session.delete(model)
+        await self.session.flush()
+        return deleted_count
+
     @staticmethod
     def _to_domain(model: TradeModel) -> Trade:
         return Trade(

api/application/trades/trade_interactor.py

@@ -172,6 +172,11 @@ async def delete_trade(self, trade_id: UUID) -> None:
 
         await self.trade_repo.delete(trade_id)
 
+    async def delete_batch_trades(self, trade_ids: List[UUID]) -> int:
+        if not trade_ids:
+            raise ValueError("No trade IDs provided")
+        return await self.trade_repo.delete_batch(trade_ids)
+
     @staticmethod
     def _trade_to_dict(trade: Trade) -> dict:
         return {

api/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "folio-api"
-version = "1.3.2"
+version = "1.4.0"
 description = "Add your description here"
 readme = "README.md"
 requires-python = ">=3.13"

api/tests/integration/http/test_trade_routes.py

@@ -80,6 +80,13 @@ async def delete_trade(self, trade_id):
         if self.mode == "delete-error":
             raise RuntimeError("delete failed")
 
+    async def delete_batch_trades(self, trade_ids):
+        if not trade_ids:
+            raise ValueError("No trade IDs provided")
+        if self.mode == "delete-error":
+            raise RuntimeError("delete failed")
+        return len(trade_ids)
+
 
 class FakeCsvImportInteractor:
     def __init__(self, mode="happy"):
@@ -337,3 +344,47 @@ def test_trade_create_update_delete_generic_exception_paths(authed_client, monke
     _patch_trade_interactor(monkeypatch, FakeTradeInteractor(mode="delete-error"))
     delete = authed_client.delete(f"/api/v1/trades/{uuid4()}")
     assert delete.status_code == 400
+
+
+@pytest.mark.integration
+@pytest.mark.happy_path
+def test_bulk_delete_trades(authed_client, monkeypatch):
+    interactor = FakeTradeInteractor()
+    _patch_trade_interactor(monkeypatch, interactor)
+    trade_ids = [str(uuid4()), str(uuid4()), str(uuid4())]
+    
+    response = authed_client.post(
+        "/api/v1/trades/bulk/delete",
+        json={"trade_ids": trade_ids},
+    )
+    
+    assert response.status_code == 204
+
+
+@pytest.mark.integration
+@pytest.mark.edge_case
+def test_bulk_delete_trades_empty_list(authed_client, monkeypatch):
+    interactor = FakeTradeInteractor()
+    _patch_trade_interactor(monkeypatch, interactor)
+    
+    response = authed_client.post(
+        "/api/v1/trades/bulk/delete",
+        json={"trade_ids": []},
+    )
+    
+    assert response.status_code == 400
+
+
+@pytest.mark.integration
+@pytest.mark.grumpy_path
+def test_bulk_delete_trades_error(authed_client, monkeypatch):
+    interactor = FakeTradeInteractor(mode="delete-error")
+    _patch_trade_interactor(monkeypatch, interactor)
+    trade_ids = [str(uuid4()), str(uuid4())]
+    
+    response = authed_client.post(
+        "/api/v1/trades/bulk/delete",
+        json={"trade_ids": trade_ids},
+    )
+    
+    assert response.status_code == 400

api/uv.lock

@@ -1,6 +1,6 @@
 {
   "name": "folio-web",
-  "version": "1.3.2",
+  "version": "1.4.0",
   "type": "module",
   "scripts": {
     "dev": "svelte-kit sync && vite",

web/package-lock.json

@@ -45,6 +45,10 @@ export class TradeController {
     await this.client.delete(`/trades/${tradeId}`);
   }
 
+  async deleteBulkTrades(tradeIds: string[]): Promise<void> {
+    await this.client.post('/trades/bulk/delete', { trade_ids: tradeIds });
+  }
+
   async validateCsv(
     file: File,
     mapping: Record<string, unknown>,

web/package.json

@@ -7,6 +7,7 @@
 
   export let trades: any[] = []
   export let loading = false
+  export let selectedIds: Set<string> = new Set()
 
   const columns = [
     { key: 'ticker', label: 'Ticker', sortable: true },
@@ -20,6 +21,7 @@
 
   let sortKey: string | null = null
   let sortDesc = false
+  let selectAll = false
 
   function handleSort(key: string) {
     if (sortKey === key) {
@@ -35,6 +37,26 @@
     })
   }
 
+  function toggleSelectAll() {
+    if (selectAll) {
+      selectedIds.clear()
+      trades.forEach(t => selectedIds.add(t.id))
+    } else {
+      selectedIds.clear()
+    }
+    selectedIds = selectedIds
+  }
+
+  function toggleSelect(tradeId: string) {
+    if (selectedIds.has(tradeId)) {
+      selectedIds.delete(tradeId)
+    } else {
+      selectedIds.add(tradeId)
+    }
+    selectedIds = selectedIds
+    selectAll = trades.length > 0 && trades.every(t => selectedIds.has(t.id))
+  }
+
   function getTradeTypeBadge(type: string): 'success' | 'danger' | 'info' | 'warning' | 'default' {
     const variants: Record<string, 'success' | 'danger' | 'info' | 'warning'> = {
       buy: 'info',
@@ -54,6 +76,15 @@
       <table class="w-full text-sm">
         <thead class="border-b border-border bg-muted">
           <tr>
+            <th class="h-12 px-4 text-left align-middle font-medium text-muted-foreground w-12">
+              <input
+                type="checkbox"
+                bind:checked={selectAll}
+                on:change={toggleSelectAll}
+                class="cursor-pointer"
+                title="Select all trades"
+              />
+            </th>
             {#each columns as col}
               <th class="h-12 px-4 text-left align-middle font-medium text-muted-foreground">
                 {#if col.sortable}
@@ -73,6 +104,14 @@
         <tbody class="[&_tr:last-child]:border-0">
           {#each trades as row (row.id)}
             <tr class="border-b border-border hover:bg-muted/50 transition-colors">
+              <td class="p-4 align-middle w-12">
+                <input
+                  type="checkbox"
+                  checked={selectedIds.has(row.id)}
+                  on:change={() => toggleSelect(row.id)}
+                  class="cursor-pointer"
+                />
+              </td>
               <td class="p-4 align-middle">{row.ticker}</td>
               <td class="p-4 align-middle">{formatDateTime(row.trade_date)}</td>
               <td class="p-4 align-middle">