fix: fix broken tests

Author: ayoub3bidi

src/pages/VisualizerApp.test.jsx

@@ -9,6 +9,7 @@ import { renderWithI18n, screen, fireEvent, waitFor } from '../test/testUtils';
 import VisualizerApp from './VisualizerApp.jsx';
 import { ThemeProvider } from '../contexts/ThemeContext.jsx';
 import { soundManager } from '../utils/soundManager';
+import { resetSoundManagerMock } from '../test/soundManagerMock.js';
 
 const { beginExportFlow, exportVideo, videoExporterMock, fullScreenMock } =
   vi.hoisted(() => {
@@ -350,11 +351,9 @@ vi.mock('../video/useVideoExporter', () => ({
 
 describe('VisualizerApp', () => {
   beforeEach(() => {
-    vi.restoreAllMocks();
+    resetSoundManagerMock();
     window.localStorage.clear();
     document.body.style.cssText = '';
-    soundManager.disable();
-    vi.clearAllMocks();
     fullScreenMock.isFullScreen = false;
     videoExporterMock.exportState = 'idle';
     videoExporterMock.exportProgress = 0;
@@ -364,6 +363,7 @@ describe('VisualizerApp', () => {
   afterEach(() => {
     vi.restoreAllMocks();
     document.body.style.cssText = '';
+    resetSoundManagerMock();
   });
 
   async function renderApp() {

src/test/setup.js

@@ -4,9 +4,10 @@
  * See LICENSE for details.
  */
 
-import { expect, afterEach, vi } from 'vitest';
+import { expect, afterEach, beforeEach, vi } from 'vitest';
 import { cleanup } from '@testing-library/react';
 import * as matchers from '@testing-library/jest-dom/matchers';
+import { resetSoundManagerMock, soundManagerMock } from './soundManagerMock.js';
 import '../i18n';
 
 // Mock constants globally to prevent import issues
@@ -253,19 +254,6 @@ vi.mock('tone', () => ({
 }));
 
 // Mock soundManager globally - prevents file execution
-const soundManagerState = {
-  isEnabled: false,
-};
-const soundManagerMock = {
-  playEvents: vi.fn(),
-  enable: vi.fn(async () => {
-    soundManagerState.isEnabled = true;
-  }),
-  disable: vi.fn(() => {
-    soundManagerState.isEnabled = false;
-  }),
-  getIsEnabled: vi.fn(() => soundManagerState.isEnabled),
-};
 vi.mock('../utils/soundManager', () => ({
   soundManager: soundManagerMock,
 }));
@@ -291,11 +279,29 @@ vi.mock('../utils/gridHelpers.js', () => gridHelpersMock);
 
 expect.extend(matchers);
 
+const originalLocalStorage = globalThis.localStorage;
+
+function restoreRealLocalStorage() {
+  if (globalThis.localStorage !== originalLocalStorage) {
+    globalThis.localStorage = originalLocalStorage;
+  }
+  try {
+    originalLocalStorage.clear();
+  } catch {
+    // Ignore storage failures in teardown.
+  }
+}
+
+beforeEach(() => {
+  restoreRealLocalStorage();
+});
+
 afterEach(() => {
   cleanup();
   vi.clearAllTimers();
-  soundManagerState.isEnabled = false;
+  resetSoundManagerMock();
   if (typeof document !== 'undefined') {
     document.body.style.cssText = '';
   }
+  restoreRealLocalStorage();
 });

src/test/soundManagerMock.js

@@ -0,0 +1,40 @@
+/**
+ * Copyright (c) 2025 Bayan Flow
+ * Licensed under Elastic License 2.0 OR Commercial
+ * See LICENSE for details.
+ */
+
+import { vi } from 'vitest';
+
+export const soundManagerState = {
+  isEnabled: false,
+};
+
+export const soundManagerMock = {
+  playEvents: vi.fn(),
+  enable: vi.fn(async () => {
+    soundManagerState.isEnabled = true;
+  }),
+  disable: vi.fn(() => {
+    soundManagerState.isEnabled = false;
+  }),
+  getIsEnabled: vi.fn(() => soundManagerState.isEnabled),
+};
+
+/** Re-apply mock implementations after vi.restoreAllMocks() in individual tests. */
+export function resetSoundManagerMock() {
+  soundManagerState.isEnabled = false;
+  soundManagerMock.enable.mockImplementation(async () => {
+    soundManagerState.isEnabled = true;
+  });
+  soundManagerMock.disable.mockImplementation(() => {
+    soundManagerState.isEnabled = false;
+  });
+  soundManagerMock.getIsEnabled.mockImplementation(
+    () => soundManagerState.isEnabled
+  );
+  soundManagerMock.playEvents.mockClear();
+  soundManagerMock.enable.mockClear();
+  soundManagerMock.disable.mockClear();
+  soundManagerMock.getIsEnabled.mockClear();
+}