Skip to content

Commit 67b947a

Browse files
committed
Accept file path to every command
1 parent 6ece7ef commit 67b947a

File tree

4 files changed

+22
-36
lines changed

4 files changed

+22
-36
lines changed

Makefile

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ boot-tools/.git:
4343
boot-tools: boot-tools/.git
4444

4545
linux-pine64-$(DATE).tar.xz: linux/arch/arm64/boot/Image boot-tools kernel/initrd.gz
46-
cd kernel && bash ./make_kernel_tarball.sh $(shell dirname $(shell readlink -f "$@"))
46+
cd kernel && \
47+
bash ./make_kernel_tarball.sh $(shell readlink -f "$@")
4748

4849
kernel-tarball: linux-pine64-$(DATE).tar.xz
4950

@@ -54,14 +55,14 @@ simple-image-pinebook-$(DATE).img: linux-pine64-$(DATE).tar.xz boot-tools
5455
bash ./make_simpleimage.sh $(shell readlink -f "$@") 100 $(shell readlink -f linux-pine64-$(DATE).tar.xz)
5556

5657
%.img.xz: %.img
57-
xz -3 $<
58+
xz -f -3 $<
5859

5960
xenial-pinebook-bspkernel-$(DATE)-$(RELEASE).img: simple-image-pinebook-$(DATE).img.xz linux-pine64-$(DATE).tar.xz boot-tools
60-
sudo MODEL=pinebook DATE=$(DATE) bash \
61-
./build-pine64-image.sh \
62-
$(shell readlink -f simple-image-pinebook.img.xz) \
61+
sudo bash ./build-pine64-image.sh \
62+
$(shell readlink -f $@) \
63+
$(shell readlink -f simple-image-pinebook-$(DATE).img.xz) \
6364
$(shell readlink -f linux-pine64-$(DATE).tar.xz) \
6465
xenial \
65-
$(RELEASE)
66+
pinebook
6667

6768
xenial-pinebook: xenial-pinebook-bspkernel-$(DATE)-$(RELEASE).img.xz

build-environment/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ RUN apt-get install -y python git-core gnupg flex bison gperf build-essential \
1010
gcc-arm-linux-gnueabi g++-arm-linux-gnueabi ccache \
1111
sudo
1212

13-
RUN apt-get install -y cpio nano vim kmod
13+
RUN apt-get install -y cpio nano vim kmod kpartx
1414

1515
RUN curl -L https://github.com/aktau/github-release/releases/download/v0.6.2/linux-amd64-github-release.tar.bz2 | tar -C /tmp -jx && \
1616
mv /tmp/bin/linux/amd64/github-release /usr/local/bin/

build-pine64-image.sh

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,18 @@
88
# - https://www.stdin.xyz/downloads/people/longsleep/pine64-images/simpleimage-pine64-latest.img.xz
99
# - https://www.stdin.xyz/downloads/people/longsleep/pine64-images/linux/linux-pine64-latest.tar.xz"
1010

11-
SIMPLEIMAGE="$1"
12-
KERNELTAR="$2"
13-
DISTRO="$3"
14-
COUNT="$4"
11+
OUT_IMAGE="$1"
12+
SIMPLEIMAGE="$2"
13+
KERNELTAR="$3"
14+
DISTRO="$4"
15+
MODEL="$5"
1516
if [[ -z "$MODEL" ]]; then
1617
MODEL="pine64"
1718
fi
1819
export MODEL
1920

2021
if [ -z "$SIMPLEIMAGE" -o -z "$KERNELTAR" ]; then
21-
echo "Usage: $0 <simpleimage.img.xz> <kernel.tar.xz> [distro] [count]"
22+
echo "Usage: $0 <result.img> <simpleimage.img.xz> <kernel.tar.xz> [distro] [model]"
2223
exit 1
2324
fi
2425

@@ -31,21 +32,15 @@ if [ -z "$DISTRO" ]; then
3132
DISTRO="xenial"
3233
fi
3334

34-
if [ -z "$COUNT" ]; then
35-
COUNT=1
36-
fi
37-
3835
SIMPLEIMAGE=$(readlink -f "$SIMPLEIMAGE")
3936
KERNELTAR=$(readlink -f "$KERNELTAR")
4037

4138
SIZE=7300 # MiB
42-
if [[ -z "$DATE" ]]; then
43-
DATE=$(date +%Y%m%d_%H%M%S_%Z)
44-
fi
4539

4640
PWD=$(readlink -f .)
4741
TEMP=$(mktemp -p $PWD -d -t "$MODEL-build-XXXXXXXXXX")
48-
IMAGE="$DISTRO-$MODEL-bspkernel-$DATE-$COUNT.img"
42+
IMAGE="$(basename "$OUT_IMAGE")"
43+
OUT_IMAGE="$(readlink -f "$IMAGE")"
4944
echo "> Building in $TEMP ..."
5045

5146
cleanup() {
@@ -55,7 +50,7 @@ cleanup() {
5550
umount $TEMP/rootfs/* || true
5651
umount "$TEMP/rootfs" || true
5752
kpartx -sd "$TEMP/$IMAGE" || true
58-
kpartx -sd "$IMAGE" || true
53+
kpartx -sd "$OUT_IMAGE" || true
5954
rmdir "$TEMP/boot"
6055
rmdir "$TEMP/rootfs"
6156
rm -r "$TEMP"
@@ -90,6 +85,6 @@ mount /dev/mapper/${DEVICENAME}p2 "$TEMP/rootfs"
9085
sleep 2
9186
(cd simpleimage && sh ./make_rootfs.sh "$TEMP/rootfs" "$KERNELTAR" "$DISTRO" "$TEMP/boot")
9287

93-
mv -v "$TEMP/$IMAGE" .
88+
mv -v "$TEMP/$IMAGE" "$OUT_IMAGE"
9489

9590
fstrim "$TEMP/rootfs"

kernel/make_kernel_tarball.sh

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ set -e
55
DEST="$1"
66

77
if [ -z "$DEST" ]; then
8-
echo "Usage: $0 <destination-folder> [linux-folder] [extra-version]"
8+
echo "Usage: $0 <destination-path> [linux-folder] [extra-version]"
99
exit 1
1010
fi
1111

@@ -41,17 +41,7 @@ cp -rv "$BOOT_TOOLS/boot/" "$TEMP/"
4141
# Use uEnv.txt.in so we do not overwrite customizations on next update.
4242
mv "$TEMP/boot/uEnv.txt" "$TEMP/boot/uEnv.txt.in"
4343

44-
if [ -z "$EXTRAVERSION" -a -e "$LINUX/.version" ]; then
45-
EXTRAVERSION=$(cat "$LINUX/.version")
46-
else
47-
EXTRAVERSION=$(date +%s)
48-
fi
49-
50-
if [ -z "$VERSION" ]; then
51-
VERSION="$(ls -1tr $TEMP/lib/modules/|tail -n1)-$EXTRAVERSION"
52-
fi
53-
54-
echo "Building $VERSION ..."
55-
tar -C "$TEMP" -cJ --owner=0 --group=0 --xform='s,./,,' -f "$DEST/linux-pine64-$VERSION.tar.xz" .
44+
echo "Building $DEST ..."
45+
tar -C "$TEMP" -cJ --owner=0 --group=0 --xform='s,./,,' -f "$DEST" .
5646

57-
echo "Done - $DEST/linux-pine64-$VERSION.tar.xz"
47+
echo "Done - $DEST"

0 commit comments

Comments
 (0)