Skip to content

Commit 38f54ed

Browse files
committed
workflow: add missing --platform to Dockerfile
1 parent 39c8913 commit 38f54ed

File tree

4 files changed

+35
-10
lines changed

4 files changed

+35
-10
lines changed

.github/ci/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
ARG DOCKER_ARCH
22
ARG DEBIAN_VERSION
3-
FROM ${DOCKER_ARCH}debian:${DEBIAN_VERSION} as build_env
3+
ARG DOCKER_REPO
4+
FROM --platform=linux/${DOCKER_ARCH} ${DOCKER_REPO}debian:${DEBIAN_VERSION} as build_env
45

56
RUN apt-get -y update && apt-get -y install gnupg2
67

.github/ci/build-env

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/bash
22

33
if [[ $# -lt 3 ]]; then
4-
echo "usage: $0 <generic|raspi> <buster|bullseye> <amd64|arm32v7|arm64v8>"
4+
echo "usage: $0 <generic|raspi> <bullseye|bookworm> <amd64|arm32v7|arm64v8>"
55
exit 1
66
fi
77

@@ -10,11 +10,14 @@ docker_image="camera_streamer_build_env"
1010
build_type="raspi"
1111
[[ -n "$1" ]] && build_type="$1"
1212

13-
debian_version="bullseye"
13+
debian_version="bookworm"
1414
[[ -n "$2" ]] && debian_version="$2" && docker_image="${docker_image}_${2}"
1515

1616
docker_arch=""
17-
[[ -n "$3" ]] && docker_arch="$3/" && docker_image="${docker_image}_${3}"
17+
[[ -n "$3" ]] && docker_arch="$3" && docker_image="${docker_image}_${3}"
18+
19+
docker_repo="${docker_arch//\//}"
20+
[[ -n "$docker_repo" ]] && docker_repo="$docker_repo/"
1821

1922
PWD=$(pwd)
2023
ROOT=$(cd -- "$( dirname -- "${BASH_SOURCE[0]}" )/../.." &> /dev/null && pwd)
@@ -23,6 +26,7 @@ set -xeo pipefail
2326

2427
docker build -t "$docker_image" \
2528
--build-arg "DOCKER_ARCH=$docker_arch" \
29+
--build-arg "DOCKER_REPO=$docker_repo" \
2630
--build-arg "DEBIAN_VERSION=$debian_version" \
2731
--build-arg "BUILD_TYPE=$build_type" \
2832
--target build_env - < .github/ci/Dockerfile

.github/workflows/build_release.yaml

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
strategy:
1010
matrix:
1111
debian_version: [bullseye, bookworm]
12-
docker_arch: [amd64, arm32v7, arm64v8]
12+
docker_arch: [amd64, arm32/v7, arm64/v8]
1313
build_type: [generic, raspi]
1414
exclude:
1515
- docker_arch: amd64
@@ -38,10 +38,20 @@ jobs:
3838
- name: Set up QEMU
3939
uses: docker/setup-qemu-action@v2
4040
- name: Build Dockerfile
41-
run: docker build --target deb_make --tag deb_make --file .github/ci/Dockerfile --build-arg GIT_VERSION --build-arg DOCKER_ARCH --build-arg DEBIAN_VERSION --build-arg BUILD_TYPE .
41+
run: |
42+
docker build \
43+
--target deb_make \
44+
--tag deb_make \
45+
--file .github/ci/Dockerfile \
46+
--build-arg GIT_VERSION \
47+
--build-arg DOCKER_ARCH \
48+
--build-arg DOCKER_REPO=${DOCKER_ARCH//\//}/ \
49+
--build-arg DEBIAN_VERSION \
50+
--build-arg BUILD_TYPE \
51+
.
4252
env:
4353
DEBIAN_VERSION: ${{ matrix.debian_version }}
44-
DOCKER_ARCH: ${{ matrix.docker_arch }}/
54+
DOCKER_ARCH: ${{ matrix.docker_arch }}
4555
BUILD_TYPE: ${{ matrix.build_type }}
4656
- name: Create container
4757
run: docker create --name deb_make deb_make

.github/workflows/build_test.yaml

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
matrix:
1414
debian_version: [bullseye, bookworm]
15-
docker_arch: [amd64, arm32v7, arm64v8]
15+
docker_arch: [amd64, arm32/v7, arm64/v8]
1616
build_type: [generic, raspi]
1717
exclude:
1818
- docker_arch: amd64
@@ -28,10 +28,20 @@ jobs:
2828
- name: Set up QEMU
2929
uses: docker/setup-qemu-action@v2
3030
- name: Build Dockerfile
31-
run: docker build --target deb_make --tag deb_make --file .github/ci/Dockerfile --build-arg GIT_VERSION --build-arg DOCKER_ARCH --build-arg DEBIAN_VERSION --build-arg BUILD_TYPE .
31+
run: |
32+
docker build \
33+
--target deb_make \
34+
--tag deb_make \
35+
--file .github/ci/Dockerfile \
36+
--build-arg GIT_VERSION \
37+
--build-arg DOCKER_ARCH \
38+
--build-arg DOCKER_REPO=${DOCKER_ARCH//\//}/ \
39+
--build-arg DEBIAN_VERSION \
40+
--build-arg BUILD_TYPE \
41+
.
3242
env:
3343
DEBIAN_VERSION: ${{ matrix.debian_version }}
34-
DOCKER_ARCH: ${{ matrix.docker_arch }}/
44+
DOCKER_ARCH: ${{ matrix.docker_arch }}
3545
BUILD_TYPE: ${{ matrix.build_type }}
3646
- name: Create container
3747
run: docker create --name deb_make deb_make

0 commit comments

Comments
 (0)