Skip to content

Commit 2f9b999

Browse files
committed
workflow: use TAG for build tgz artifacts
1 parent ac5f338 commit 2f9b999

File tree

3 files changed

+22
-19
lines changed

3 files changed

+22
-19
lines changed

dockerfiles/Dockerfile.build

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,10 @@ COPY --from=builder /src/release/ /release/
6464
# Bundle server
6565
ARG VERSION
6666
ARG ARCH=
67+
ARG TAG=
6768
ADD /scripts/release /src/scripts/release
6869
RUN /src/scripts/release/apt-install.bash --gen /release/install /release proxmox-backup-server
69-
RUN /src/scripts/release/bundle-tgz.bash /proxmox-backup-server-${VERSION}-${ARCH:-dev}.tgz /release/.
70+
RUN /src/scripts/release/bundle-tgz.bash /proxmox-backup-server-${TAG:-$VERSION}-${ARCH:-dev}.tgz /release/.
7071

7172
#=================================
7273

dockerfiles/Dockerfile.client

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,10 @@ RUN ./scripts/build/make.bash --keep proxmox-backup "make . ignore proxmox-backu
3939
# Bundle client
4040
ARG VERSION
4141
ARG ARCH=
42+
ARG TAG=
4243
ADD /dockerfiles/client/ /dockerfiles/client/
4344
ADD /scripts/release /src/scripts/release
44-
RUN /src/scripts/release/bundle-tgz.bash /proxmox-backup-client-${VERSION}-${CROSS_ARCH:-${ARCH:-dev}}.tgz \
45+
RUN /src/scripts/release/bundle-tgz.bash /proxmox-backup-client-${TAG:-${VERSION}}-${CROSS_ARCH:-${ARCH:-dev}}.tgz \
4546
/dockerfiles/client/. \
4647
/src/build/proxmox-backup/target/static-build/*/release/pxar \
4748
/src/build/proxmox-backup/target/static-build/*/release/proxmox-backup-client

release.bash

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ fi
88
SCRIPT_DIR="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
99
cd "$SCRIPT_DIR/"
1010

11-
TAG="$1"
11+
IMAGE_TAG="$1"
1212
shift
1313

1414
set -xeo pipefail
@@ -46,16 +46,17 @@ case "$ARCH" in
4646
;;
4747
esac
4848

49-
RELEASE_TAG="$TAG-${CROSS_ARCH:-$ARCH}"
50-
BUILD_TAG="$TAG-build-${CROSS_ARCH:-$ARCH}"
51-
DEB_TAG="$TAG-deb-${CROSS_ARCH:-$ARCH}"
52-
CLIENT_TAG="$TAG-client-${CROSS_ARCH:-$ARCH}"
49+
RELEASE_IMAGE_TAG="$IMAGE_TAG-${CROSS_ARCH:-$ARCH}"
50+
BUILD_IMAGE_TAG="$IMAGE_TAG-build-${CROSS_ARCH:-$ARCH}"
51+
DEB_IMAGE_TAG="$IMAGE_TAG-deb-${CROSS_ARCH:-$ARCH}"
52+
CLIENT_IMAGE_TAG="$IMAGE_TAG-client-${CROSS_ARCH:-$ARCH}"
5353

5454
docker_build() {
5555
docker build \
5656
--build-arg=ARCH="$ARCH" \
5757
--build-arg=CROSS_ARCH="$CROSS_ARCH" \
5858
--build-arg=VERSION="$VERSION" \
59+
--build-arg=TAG="$TAG" \
5960
--build-arg=IMAGE_PREFIX="$IMAGE_PREFIX" \
6061
--platform="$TARGET_PLATFORM" \
6162
"$@"
@@ -64,37 +65,37 @@ docker_build() {
6465
for i; do
6566
case "$i" in
6667
build-deb)
67-
docker_build --file=dockerfiles/Dockerfile.build --target="deb_env" --tag="$DEB_TAG" "."
68-
docker run --rm -v "$PWD":/dest "$DEB_TAG" sh -c 'cp -rv /release /dest'
68+
docker_build --file=dockerfiles/Dockerfile.build --target="deb_env" --tag="$DEB_IMAGE_TAG" "."
69+
docker run --rm -v "$PWD":/dest "$DEB_IMAGE_TAG" sh -c 'cp -rv /release /dest'
6970
;;
7071

7172
build-tgz)
72-
docker_build --file=dockerfiles/Dockerfile.build --target="deb_env" --tag="$DEB_TAG" "."
73+
docker_build --file=dockerfiles/Dockerfile.build --target="deb_env" --tag="$DEB_IMAGE_TAG" "."
7374
mkdir -p release/
74-
docker run --rm -v "$PWD":/dest "$DEB_TAG" sh -c 'cp -rv /*.tgz /dest/release/'
75+
docker run --rm -v "$PWD":/dest "$DEB_IMAGE_TAG" sh -c 'cp -rv /*.tgz /dest/release/'
7576
;;
7677

7778
build-image)
78-
docker_build --file=dockerfiles/Dockerfile.build --target="release_env" --tag="$RELEASE_TAG" "."
79+
docker_build --file=dockerfiles/Dockerfile.build --target="release_env" --tag="$RELEASE_IMAGE_TAG" "."
7980
;;
8081

8182
client-tgz)
82-
docker_build --file=dockerfiles/Dockerfile.client --tag="$CLIENT_TAG" "."
83+
docker_build --file=dockerfiles/Dockerfile.client --tag="$CLIENT_IMAGE_TAG" "."
8384
mkdir -p release/
84-
docker run --rm -v "$PWD":/dest "$CLIENT_TAG" sh -c 'cp -rv /*.tgz /dest/release/'
85+
docker run --rm -v "$PWD":/dest "$CLIENT_IMAGE_TAG" sh -c 'cp -rv /*.tgz /dest/release/'
8586
;;
8687

8788
push-image)
88-
docker push "$RELEASE_TAG"
89+
docker push "$RELEASE_IMAGE_TAG"
8990
;;
9091

9192
manifest)
9293
MANIFEST_ARCHS=""
9394
for i in $ARCHS; do
94-
if docker manifest inspect "$TAG-$i" &>/dev/null; then
95-
MANIFEST_ARCHS="$MANIFEST_ARCHS $TAG-$i"
95+
if docker manifest inspect "$IMAGE_TAG-$i" &>/dev/null; then
96+
MANIFEST_ARCHS="$MANIFEST_ARCHS $IMAGE_TAG-$i"
9697
else
97-
echo "Manifest for $TAG-$i does not exist, skipping."
98+
echo "Manifest for $IMAGE_TAG-$i does not exist, skipping."
9899
fi
99100
done
100101

@@ -119,7 +120,7 @@ for i; do
119120

120121
shift
121122

122-
for i in $(manifest_names "$TAG" "$@"); do
123+
for i in $(manifest_names "$IMAGE_TAG" "$@"); do
123124
docker manifest create "$i" $MANIFEST_ARCHS
124125
docker manifest push "$i"
125126
done

0 commit comments

Comments
 (0)