Skip to content

Commit 3a83d56

Browse files
committed
Update ESPDash.cpp
Fixed C++ Mistakes and Allocated more memory to LineChart Update Function
1 parent 00e14ef commit 3a83d56

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

src/ESPDash.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ void ESPDashClass::init(AsyncWebServer& server){
150150

151151
// Add Number Card with Default Value
152152
void ESPDashClass::addNumberCard(const char* _id, const char* _name){
153-
if(_id != ""){
153+
if(_id != NULL){
154154
for(int i=0; i < NUMBER_CARD_LIMIT; i++){
155155
if(number_card_id[i] == ""){
156156
if(DEBUG_MODE){
@@ -174,7 +174,7 @@ void ESPDashClass::addNumberCard(const char* _id, const char* _name){
174174

175175
// Add Number Card with Custom Value
176176
void ESPDashClass::addNumberCard(const char* _id, const char* _name, int _value){
177-
if(_id != ""){
177+
if(_id != NULL){
178178
for(int i=0; i < NUMBER_CARD_LIMIT; i++){
179179
if(number_card_id[i] == ""){
180180
if(DEBUG_MODE){
@@ -235,7 +235,7 @@ void ESPDashClass::updateNumberCard(const char* _id, int _value){
235235

236236
// Add Temperature Card with Default Value
237237
void ESPDashClass::addTemperatureCard(const char* _id, const char* _name, int _type){
238-
if(_id != "" && _type >= 0 && _type <= TEMPERATURE_CARD_TYPES){
238+
if(_id != NULL && _type >= 0 && _type <= TEMPERATURE_CARD_TYPES){
239239
for(int i=0; i < TEMPERATURE_CARD_LIMIT; i++){
240240
if(temperature_card_id[i] == ""){
241241
if(DEBUG_MODE){
@@ -260,7 +260,7 @@ void ESPDashClass::addTemperatureCard(const char* _id, const char* _name, int _t
260260

261261
// Add Temperature Card with Custom Value
262262
void ESPDashClass::addTemperatureCard(const char* _id, const char* _name, int _type, int _value){
263-
if(_id != "" && _type >= 0 && _type <= TEMPERATURE_CARD_TYPES){
263+
if(_id != NULL && _type >= 0 && _type <= TEMPERATURE_CARD_TYPES){
264264
for(int i=0; i < TEMPERATURE_CARD_LIMIT; i++){
265265
if(temperature_card_id[i] == ""){
266266
if(DEBUG_MODE){
@@ -322,7 +322,7 @@ void ESPDashClass::updateTemperatureCard(const char* _id, int _value){
322322

323323
// Add Humidity Card with Default Value
324324
void ESPDashClass::addHumidityCard(const char* _id, const char* _name){
325-
if(_id != ""){
325+
if(_id != NULL){
326326
for(int i=0; i < HUMIDITY_CARD_LIMIT; i++){
327327
if(humidity_card_id[i] == ""){
328328
if(DEBUG_MODE){
@@ -346,7 +346,7 @@ void ESPDashClass::addHumidityCard(const char* _id, const char* _name){
346346

347347
// Add Humidity Card with Custom Value
348348
void ESPDashClass::addHumidityCard(const char* _id, const char* _name, int _value){
349-
if(_id != ""){
349+
if(_id != NULL){
350350
for(int i=0; i < HUMIDITY_CARD_LIMIT; i++){
351351
if(humidity_card_id[i] == ""){
352352
if(DEBUG_MODE){
@@ -407,7 +407,7 @@ void ESPDashClass::updateHumidityCard(const char* _id, int _value){
407407

408408
// Add Status Card with Default Value
409409
void ESPDashClass::addStatusCard(const char* _id, const char* _name){
410-
if(_id != ""){
410+
if(_id != NULL){
411411
for(int i=0; i < STATUS_CARD_LIMIT; i++){
412412
if(status_card_id[i] == ""){
413413
if(DEBUG_MODE){
@@ -431,7 +431,7 @@ void ESPDashClass::addStatusCard(const char* _id, const char* _name){
431431

432432
// Add Status Card with Custom Value
433433
void ESPDashClass::addStatusCard(const char* _id, const char* _name, int _value){
434-
if(_id != "" && _value >= 0 && _value <= STATUS_CARD_TYPES){
434+
if(_id != NULL && _value >= 0 && _value <= STATUS_CARD_TYPES){
435435
for(int i=0; i < STATUS_CARD_LIMIT; i++){
436436
if(status_card_id[i] == ""){
437437
if(DEBUG_MODE){
@@ -455,7 +455,7 @@ void ESPDashClass::addStatusCard(const char* _id, const char* _name, int _value)
455455

456456
// Add Status Card with Custom Boolean Value
457457
void ESPDashClass::addStatusCard(const char* _id, const char* _name, bool _value){
458-
if(_id != ""){
458+
if(_id != NULL){
459459
for(int i=0; i < STATUS_CARD_LIMIT; i++){
460460
if(status_card_id[i] == ""){
461461
if(DEBUG_MODE){
@@ -560,7 +560,7 @@ void ESPDashClass::updateStatusCard(const char* _id, int _value){
560560

561561
// Add Button Card
562562
void ESPDashClass::addButtonCard(const char* _id, const char* _name){
563-
if(_id != ""){
563+
if(_id != NULL){
564564
for(int i=0; i < BUTTON_CARD_LIMIT; i++){
565565
if(button_card_id[i] == ""){
566566
if(DEBUG_MODE){
@@ -586,7 +586,7 @@ void ESPDashClass::addButtonCard(const char* _id, const char* _name){
586586

587587
// Add Line Chart
588588
void ESPDashClass::addLineChart(const char* _id, const char* _name, int _x_axis_value[], int _x_axis_size, const char* _y_axis_name, int _y_axis_value[], int _y_axis_size){
589-
if(_id != ""){
589+
if(_id != NULL){
590590
for(int i=0; i < LINE_CHART_LIMIT; i++){
591591
if(line_chart_id[i] == ""){
592592
if(DEBUG_MODE){
@@ -620,7 +620,7 @@ void ESPDashClass::addLineChart(const char* _id, const char* _name, int _x_axis_
620620

621621
// Add Line Chart
622622
void ESPDashClass::addLineChart(const char* _id, const char* _name, String _x_axis_value[], int _x_axis_size, const char* _y_axis_name, int _y_axis_value[], int _y_axis_size){
623-
if(_id != ""){
623+
if(_id != NULL){
624624
for(int i=0; i < LINE_CHART_LIMIT; i++){
625625
if(line_chart_id[i] == ""){
626626
if(DEBUG_MODE){
@@ -711,7 +711,7 @@ void ESPDashClass::updateLineChart(const char* _id, String _x_axis_value[], int
711711

712712
if(line_chart_x_axis_type[i] == true){
713713

714-
DynamicJsonDocument doc(250);
714+
DynamicJsonDocument doc(1000);
715715
JsonObject object = doc.to<JsonObject>();
716716
object["response"] = "updateLineChart";
717717
object["id"] = line_chart_id[i];

0 commit comments

Comments
 (0)