@@ -29,14 +29,17 @@ const MAX_DISTANCE = 130000
2929const MAX_TRAVEL_TIME = 120
3030const MIN_QUINTILE = 1
3131const MAX_QUINTILE = 5
32+ // stored profile importance is offset by one from MAX_IMPORTANCE
33+ const PROFILE_MAX_IMPORTANCE = MAX_IMPORTANCE - 1
3234
3335// default to worst, if unknown
3436const DEFAULT_EDUCATION_QUINTILE = 5
3537const DEFAULT_CRIME_QUINTILE = 5
3638
3739// extra constant weighting always given to travel time over the other two factors
38- const EXTRA_ACCESS_WEIGHT = 1
40+ const EXTRA_ACCESS_WEIGHT = 2
3941
42+ /* eslint complexity: 0 */
4043export default createSelector (
4144 selectNeighborhoodRoutes ,
4245 neighborhoodTravelTimes ,
@@ -64,63 +67,89 @@ export default createSelector(
6467 accessibilityImportance = crimeImportance = schoolsImportance = 1
6568 }
6669
67- // Give accessibility (travel time) extra weighting
70+ if ( accessibilityImportance === PROFILE_MAX_IMPORTANCE ) {
71+ // if set to very important, add more extra weight to travel time
72+ accessibilityImportance += 1
73+ }
74+
75+ // Alwasy give accessibility (travel time) some extra weighting
6876 accessibilityImportance += EXTRA_ACCESS_WEIGHT
6977
7078 const totalImportance = accessibilityImportance + crimeImportance + schoolsImportance
7179
72- let accessibilityPercent = accessibilityImportance / totalImportance
73- let crimePercent = crimeImportance / totalImportance
74- let schoolPercent = schoolsImportance / totalImportance
75-
7680 const neighborhoodsWithRoutes = filter ( neighborhoods . features . map ( ( n , index ) => {
81+ let accessibilityPercent = accessibilityImportance / totalImportance
82+ let crimePercent = crimeImportance / totalImportance
83+ let schoolPercent = schoolsImportance / totalImportance
84+
7785 const properties : NeighborhoodProperties = n . properties
7886 const route = neighborhoodRoutes [ index ]
7987 const segments = useTransit ? route . routeSegments : [ ]
8088 const time = useTransit ? travelTimes [ index ] : distanceTime ( origin , n )
81-
82- // Map weighting values to percentages
83-
8489 // Routable neighborhoods outside the max travel time window will be filtered out.
8590 // Smaller travel time is better; larger timeWeight is better (reverse range).
8691 const timeWeight = time < MAX_TRAVEL_TIME ? scale ( time , 0 , MAX_TRAVEL_TIME , 1 , 0 ) : 1
87-
8892 // Weight schools either by percentile binned into quarters if given max importance,
8993 // or otherwise weight by quintile.
9094 let educationWeight
91- if ( schoolsImportance === ( MAX_IMPORTANCE - 1 ) ) {
92- // Group percentile ranking into quarters instead of using quintiles
93- // if the importance of schools is the max importance.
95+ if ( schoolsImportance === PROFILE_MAX_IMPORTANCE ) {
96+ // "very important": instead of quintiles, group percentile ranking into quarters
9497 const edPercent = properties . education_percentile
9598 ? properties . education_percentile
9699 : ( DEFAULT_EDUCATION_QUINTILE - 1 ) * 20
97- const edPercentQuarter = Math . round ( scale ( edPercent , 0 , 100 , 3 , 0 ) )
100+ let edPercentQuarter = Math . round ( scale ( edPercent , 0 , 100 , 3 , 0 ) )
101+ // Treat all schools not in the top quarter as being in the bottom quarter
102+ // to strongly prioritize the top quarter
103+ if ( edPercentQuarter > 0 ) {
104+ edPercentQuarter = 3
105+ }
98106 educationWeight = scale ( edPercentQuarter , 0 , 3 , 1 , 0 )
99- } else {
100- // Use quintiles if the importance of schools is anything less than the max importance.
101- const educationQuintile = properties . education_percentile_quintile
107+ } else if ( schoolsImportance > 0 ) {
108+ // For "somewhat important", prioritize quintile 2 and below
109+ // For "important", quintile 3 and below (lower is better)
110+ const prioritizeQuintile = schoolsImportance === 1 ? 2 : 3
111+ let educationQuintile = properties . education_percentile_quintile
102112 ? properties . education_percentile_quintile
103113 : DEFAULT_EDUCATION_QUINTILE
104-
114+ // Treat all quintiles above the maximum to prioritize as being in the worst quintile
115+ if ( educationQuintile > prioritizeQuintile ) {
116+ educationQuintile = MAX_QUINTILE
117+ }
105118 // Lowest education quintile is best (reverse range).
106119 educationWeight = scale ( educationQuintile , MIN_QUINTILE , MAX_QUINTILE , 1 , 0 )
120+ } else {
121+ educationWeight = 0 // Not important
107122 }
108- let crimeQuintile = properties . violentcrime_quintile
109- ? properties . violentcrime_quintile : DEFAULT_CRIME_QUINTILE
110- // Treat lowest two (safest) violent crime quintiles equally
111- if ( crimeQuintile === 2 ) {
112- crimeQuintile = 1
113- }
114- // Lowest crime quintile is best (reverse range).
115- const crimeWeight = scale ( crimeQuintile , MIN_QUINTILE , MAX_QUINTILE , 1 , 0 )
116-
123+ let crimeWeight = 0
117124 // Handle missing values (zero in spreadsheet) by re-assigning crime weight
118- // evenly to the other two factors
119- if ( properties . violentcrime_quintile === 0 ) {
125+ // evenly to the other two factors. Also do so if crime set as unimportant.
126+ if ( properties . violentcrime_quintile === 0 || crimeImportance === 0 ) {
120127 const halfCrimePercent = crimePercent / 2
121128 schoolPercent += halfCrimePercent
122129 accessibilityPercent += halfCrimePercent
123130 crimePercent = 0
131+ } else {
132+ let crimeQuintile = properties . violentcrime_quintile
133+ ? properties . violentcrime_quintile : DEFAULT_CRIME_QUINTILE
134+ // Treat lowest two (safest) violent crime quintiles equally
135+ if ( crimeQuintile === 2 ) {
136+ crimeQuintile = 1
137+ }
138+ if ( crimeImportance === 1 && crimeQuintile < 5 ) {
139+ // somewhat important; treat all but worst quintile the same
140+ crimeQuintile = 1
141+ } else if ( crimeImportance === 2 && crimeQuintile < 4 ) {
142+ // "important"; treat all but worst two quintiles the same
143+ crimeQuintile = 1
144+ } else if ( crimeImportance === PROFILE_MAX_IMPORTANCE && crimeQuintile > 3 ) {
145+ // "very important"; push results for worst two quintiles to bottom
146+ // by reassigning weights for those quintiles to be 90% crime
147+ crimePercent = 0.9
148+ schoolPercent /= 10
149+ accessibilityPercent /= 10
150+ }
151+ // Lowest crime quintile is best (reverse range).
152+ crimeWeight = scale ( crimeQuintile , MIN_QUINTILE , MAX_QUINTILE , 1 , 0 )
124153 }
125154
126155 // Calculate weighted overall score from the percentages. Larger score is better.
0 commit comments