Fix unroutable timeWeight assignment

If a neighborhood is unroutable we don't create an scaled accessibility weight but instead define a default weight value, 1. This is the "best" weight, but because there is no route information to evaluate these neighborhoods were previously being binned in the "too far" list and the accessibility sorting doesn't matter. Now that unroutable neighborhoods can be recommended, the weight actually holds value in the overall score. Instead we should set these neighborhoods to the worst weighted value, 0, so unroutable neighborhoods will be sorted to the bottom of the recommendation list, as needed.

Author: rachelekm

src/frontend/src/reducers/neighborhoods/utils/createNeighborhoodWeightedScore.ts

@@ -46,7 +46,7 @@ export const createNeighborhoodWeightedScore = (
     // Routable neighborhoods outside the max travel time window filtered into separate list.
     // Smaller travel time is better; larger timeWeight is better (reverse range).
     const timeWeight =
-        time < MAX_TRAVEL_TIME ? scale(time, 0, MAX_TRAVEL_TIME, 1, 0) : 1;
+        time < MAX_TRAVEL_TIME ? scale(time, 0, MAX_TRAVEL_TIME, 1, 0) : 0;
     // Weight schools either by percentile binned into quarters if given max importance,
     // or otherwise weight by quintile.
     let educationWeight;