[Warrior, Regression] - Swapping during "Bladestorm" will cause it to be interrupted, it shouldn't

[TheSCREWEDSoftware]

Triage

Issue linked from CC: chromiecraft/chromiecraft#8877

Triage Notes:

• Make a Orc Warrior
• .additem 37 // 1H Axe
• .additem 14393 // Shield
• Equip both (Swapping your current 2H axe)
• .level 79
• .learn all my class
• .cheat cooldown
• .cheat power
• Use bladestorm and while is active swap between weapons and see it being canceled, it shouldnt

CC: @sogladev iirc, it was a recent change of yours that did this?

This is my guess based on the callstack (pasted below) azerothcore/azerothcore-wotlk@2f7f9bd

CC: @Tereneckla

if you happen to have an immediate idea what goes wrong? Although, best to move this discussion to AC

call stack

CC @Tereneckla

Original Post Below:

---

Current Behaviour

Before was working properly, some other fix might have interfered with it, basically when u bladestorm in 1h+ shield and swap to 2h bladestorm get cancelled .

Expected Behaviour

if u bladestorm in 1h + shield and you swap 2h during bladestorm, it dosen't get interrupted . Before was working properly during all progressiones phases.

Source

https://www.youtube.com/watch?v=9YBxx0GiRuM&t=52s

start minute 11:40 put in slow x0.25 at 11:41 u can see he start bladestorm with 1h and shield swapping during it , and u can see clearly it not gettting interupted by the action itself but by the warrior dismantle(disarm)

Steps to reproduce the problem

1 equip 1hand and shield and cast bladestorm
2 during bladestorm equip 2h weapon
3 bladestorm get interrupted

Extra Notes

No response

Customizations

No response

AC rev. hash/commit

chromiecraft@a4ea6d6

Operating system

Ubuntu 22.04

Modules

• mod-1v1-arena
• mod-ah-bot
• mod-anticheat
• mod-arena-3v3-solo-queue
• mod-arena-replay
• mod-bg-item-reward
• mod-breaking-news-override
• mod-cfbg
• mod-chat-transmitter
• mod-chromie-xp
• mod-chromiecraft-smartstone
• mod-costumes
• mod-cta-switch
• mod-desertion-warnings
• mod-dmf-switch
• mod-duel-reset
• mod-eluna
• mod-evade-logging
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-npc-spectator
• mod-progression-system
• mod-pvp-quests
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-CarbonCopy
• lua-eventScripts
• lua-ExchangeNpc
• lua-LevelUpReward
• lua-RecruitAFriend
• lua-SendAndBind
• lua-TempAnnouncements
• lua-Zonecheck

Server

ChromieCraft