(PlayerMethods): Taxi Node Improvements (#357)

Author: Aldori15

src/LuaEngine/LuaFunctions.cpp

@@ -707,6 +707,7 @@ ALERegister<Player> PlayerMethods[] =
     { "IsAtLootRewardDistance", &LuaPlayer::IsAtLootRewardDistance },
     { "CanTeleport", &LuaPlayer::CanTeleport },
     { "IsSpectator", &LuaPlayer::IsSpectator },
+    { "HasKnownTaxiNode", &LuaPlayer::HasKnownTaxiNode },
     // { "HasSpellMod", &LuaPlayer::HasSpellMod },
 
     // Gossip

src/LuaEngine/methods/PlayerMethods.h

@@ -1634,18 +1634,20 @@ namespace LuaPlayer
         ByteBuffer data;
         player->m_taxi.AppendTaximaskTo(data, false);
 
+        uint32 idx = 1;
+
         for (uint8 i = 0; i < TaxiMaskSize; i++)
         {
             uint32 mask;
             data >> mask;
 
             for (uint8 bit = 0; bit < 32; bit++)
             {
-                if (mask & (1 << bit))
+                if (mask & (1u << bit))
                 {
                     uint32 nodeId = (i * 32) + bit + 1;
                     lua_pushinteger(L, nodeId);
-                    lua_rawseti(L, -2, lua_rawlen(L, -2) + 1);
+                    lua_rawseti(L, -2, idx++);
                 }
             }
         }
@@ -4981,6 +4983,32 @@ namespace LuaPlayer
         player->ApplyRatingMod(CombatRating(stat), value, apply);
         return 0;
     }
+
+    /**
+     * Returns `true` if the [Player] knows the given taxi node, `false` otherwise.
+     *
+     * @param uint32 nodeId
+     * @return bool known
+     */
+    int HasKnownTaxiNode(lua_State* L, Player* player)
+    {
+        if (!player)
+        {
+            ALE::Push(L, false);
+            return 1;
+        }
+
+        uint32 nodeId = ALE::CHECKVAL<uint32>(L, 2);
+
+        if (nodeId == 0)
+        {
+            ALE::Push(L, false);
+            return 1;
+        }
+
+        ALE::Push(L, player->m_taxi.IsTaximaskNodeKnown(nodeId));
+        return 1;
+    }
 };
 #endif