feat: Add ShouldNerfMap() helper

Author: Nyeriah

src/ZoneDifficulty.h

@@ -140,6 +140,7 @@ class ZoneDifficulty
     [[nodiscard]] bool VectorContainsUint32(std::vector<uint32> vec, uint32 element);
     [[nodiscard]] bool IsMythicmodeMap(uint32 mapid);
     [[nodiscard]] bool ShouldNerfInDuels(Unit* target);
+    [[nodiscard]] bool ShouldNerfMap(uint32 mapId) { return NerfInfo.find(mapId) != NerfInfo.end(); };
     [[nodiscard]] int32 GetLowestMatchingPhase(uint32 mapId, uint32 phaseMask);
 
     bool IsEnabled{ false };

src/mod_zone_difficulty_scripts.cpp

@@ -39,7 +39,7 @@ class mod_zone_difficulty_unitscript : public UnitScript
             bool nerfInDuel = sZoneDifficulty->ShouldNerfInDuels(target);
 
             //Check if the map of the target is subject of a nerf at all OR if the target is subject of a nerf in a duel
-            if (sZoneDifficulty->NerfInfo.find(mapId) != sZoneDifficulty->NerfInfo.end() || nerfInDuel)
+            if (sZoneDifficulty->ShouldNerfMap(mapId) || nerfInDuel)
             {
                 if (SpellInfo const* spellInfo = aura->GetSpellInfo())
                 {
@@ -152,7 +152,7 @@ class mod_zone_difficulty_unitscript : public UnitScript
             uint32 mapId = target->GetMapId();
             bool nerfInDuel = sZoneDifficulty->ShouldNerfInDuels(target);
             //Check if the map of the target is subject of a nerf at all OR if the target is subject of a nerf in a duel
-            if (sZoneDifficulty->NerfInfo.find(mapId) != sZoneDifficulty->NerfInfo.end() || sZoneDifficulty->ShouldNerfInDuels(target))
+            if (sZoneDifficulty->ShouldNerfMap(mapId) || sZoneDifficulty->ShouldNerfInDuels(target))
             {
                 //This check must be first and skip the rest to override everything else.
                 if (spellInfo)
@@ -255,7 +255,7 @@ class mod_zone_difficulty_unitscript : public UnitScript
                 }
             }
 
-            if (sZoneDifficulty->NerfInfo.find(mapId) != sZoneDifficulty->NerfInfo.end() && matchingPhase != -1)
+            if (sZoneDifficulty->ShouldNerfMap(mapId) && matchingPhase != -1)
             {
                 int8 mode = sZoneDifficulty->NerfInfo[mapId][matchingPhase].Enabled;
                 Map* map = target->GetMap();
@@ -354,7 +354,7 @@ class mod_zone_difficulty_unitscript : public UnitScript
                 }
             }
 
-            if (sZoneDifficulty->NerfInfo.find(mapId) != sZoneDifficulty->NerfInfo.end() && matchingPhase != -1)
+            if (sZoneDifficulty->ShouldNerfMap(mapId) && matchingPhase != -1)
             {
                 int8 mode = sZoneDifficulty->NerfInfo[mapId][matchingPhase].Enabled;
                 Map* map = target->GetMap();
@@ -417,7 +417,7 @@ class mod_zone_difficulty_unitscript : public UnitScript
             uint32 mapId = target->GetMapId();
             uint32 phaseMask = target->GetPhaseMask();
             int matchingPhase = sZoneDifficulty->GetLowestMatchingPhase(mapId, phaseMask);
-            if (sZoneDifficulty->NerfInfo.find(mapId) != sZoneDifficulty->NerfInfo.end() && matchingPhase != -1)
+            if (sZoneDifficulty->ShouldNerfMap(mapId) && matchingPhase != -1)
             {
                 int8 mode = sZoneDifficulty->NerfInfo[mapId][matchingPhase].Enabled;
                 Map* map = target->GetMap();