Skip to content

Commit 402d341

Browse files
authored
Use commonly defined go N0, N-1 versions in test matrix configs (Azure#24296)
* Use centralized variables for go N version testing * Use GO_VERSION_LATEST convention * Add go version clarity to job/step titles
1 parent 64a8cbc commit 402d341

File tree

6 files changed

+17
-13
lines changed

6 files changed

+17
-13
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
{
22
"matrix": {
33
"Agent": {
4-
"ubuntu-20.04": {
4+
"ubuntu_go": {
55
"OSVmImage": "env:LINUXVMIMAGE",
66
"Pool": "env:LINUXPOOL"
77
},
8-
"windows-2022": {
8+
"windows_go": {
99
"OSVmImage": "env:WINDOWSVMIMAGE",
1010
"Pool": "env:WINDOWSPOOL"
1111
}
1212
},
1313
"GoVersion": [
14-
"1.23.7",
15-
"1.24.1"
14+
"env:GO_VERSION_LATEST",
15+
"env:GO_VERSION_PREVIOUS"
1616
]
1717
}
1818
}

eng/pipelines/templates/steps/build-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ steps:
7676

7777
- ${{ if parameters.UseFederatedAuth }}:
7878
- task: AzurePowerShell@5
79-
displayName: Run Tests (Federated Auth)
79+
displayName: Run Tests - v$(GoVersion) (Federated Auth)
8080
inputs:
8181
azureSubscription: ${{ parameters.ServiceConnection }}
8282
azurePowerShellVersion: LatestVersion
@@ -116,7 +116,7 @@ steps:
116116

117117
- ${{ else }}:
118118
- task: PowerShell@2
119-
displayName: 'Run Tests'
119+
displayName: Run Tests - v$(GoVersion)
120120
inputs:
121121
targetType: 'filePath'
122122
filePath: ./eng/scripts/run_tests.ps1

eng/pipelines/templates/variables/globals.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,7 @@ variables:
2020

2121
# disable code coverage redesign until it's been fixed (causes inadvertent deflation of CC numbers)
2222
GOEXPERIMENT: nocoverageredesign
23+
24+
# Supported versions for testing. These variables are referenced in test matrix files.
25+
GO_VERSION_LATEST: 1.24.1
26+
GO_VERSION_PREVIOUS: 1.23.7

sdk/azidentity/managed-identity-matrix.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
}
1010
},
1111
"GoVersion": [
12-
"1.22.1"
12+
"env:GO_VERSION_PREVIOUS"
1313
],
1414
"IDENTITY_IMDS_AVAILABLE": "1"
1515
}

sdk/security/keyvault/azadmin/platform-matrix.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
"include": [
66
{
77
"Agent": {
8-
"ubuntu-20.04": {
8+
"ubuntu_go": {
99
"OSVmImage": "env:LINUXVMIMAGE",
1010
"Pool": "env:LINUXPOOL"
1111
}
1212
},
13-
"ArmTemplateParameters": "@{ enableHsm = $true }",
14-
"GoVersion": ["1.23.7"]
13+
"GoVersion": ["env:GO_VERSION_PREVIOUS"],
14+
"ArmTemplateParameters": "@{ enableHsm = $true }"
1515
}
1616
]
1717
}

sdk/security/keyvault/azkeys/platform-matrix.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
"include": [
66
{
77
"Agent": {
8-
"ubuntu-20.04": {
8+
"ubuntu_go": {
99
"OSVmImage": "env:LINUXVMIMAGE",
1010
"Pool": "env:LINUXPOOL"
1111
}
1212
},
13-
"ArmTemplateParameters": "@{ enableHsm = $true }",
14-
"GoVersion": ["1.23.7"]
13+
"GoVersion": ["env:GO_VERSION_PREVIOUS"],
14+
"ArmTemplateParameters": "@{ enableHsm = $true }"
1515
}
1616
]
1717
}

0 commit comments

Comments
 (0)