[Storage][Azfile] Fixed create File Api on passing permissionKey (Azure#24813)

* Fixed create File Api

* fixed the logic according to the documentation

* recording

Author: tanyasethi-msft

sdk/storage/azfile/CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+* Fixed bug where fileClient.Create API call was failing on passing permissionKey parameter. Fixes[#24632(https://github.com/Azure/azure-sdk-for-go/issues/24632)]
 
 ### Other Changes
 

sdk/storage/azfile/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "go",
   "TagPrefix": "go/storage/azfile",
-  "Tag": "go/storage/azfile_8ed895c5cb"
+  "Tag": "go/storage/azfile_ea4253f034"
 }

sdk/storage/azfile/file/client_test.go

@@ -421,6 +421,36 @@ func (f *FileRecordedTestsSuite) TestFileCreateNegativeMetadataInvalid() {
 	_require.Error(err)
 }
 
+func (f *FileRecordedTestsSuite) TestFileCreateWithPermissionKey() {
+	_require := require.New(f.T())
+	testName := f.T().Name()
+
+	svcClient, err := testcommon.GetServiceClient(f.T(), testcommon.TestAccountDefault, nil)
+	_require.NoError(err)
+
+	shareName := testcommon.GenerateShareName(testName)
+	shareClient := testcommon.CreateNewShare(context.Background(), _require, shareName, svcClient)
+	defer testcommon.DeleteShare(context.Background(), _require, shareClient)
+
+	createResp, err := shareClient.CreatePermission(context.Background(), testcommon.SampleSDDL, nil)
+	_require.NoError(err)
+	_require.NotNil(createResp.FilePermissionKey)
+	_require.NotEmpty(*createResp.FilePermissionKey)
+
+	fileName := testcommon.GenerateFileName(testName)
+	fileClient := shareClient.NewRootDirectoryClient().NewFileClient(fileName)
+	_, err = fileClient.Create(context.Background(), 1024, &file.CreateOptions{
+		Permissions: &file.Permissions{
+			PermissionKey: createResp.FilePermissionKey,
+		},
+	})
+	_require.NoError(err)
+
+	getResp, err := fileClient.GetProperties(context.Background(), nil)
+	_require.NoError(err)
+	_require.NotNil(getResp.FilePermissionKey)
+}
+
 func (f *FileRecordedTestsSuite) TestCreateFileNFS() {
 	_require := require.New(f.T())
 	testName := f.T().Name()

sdk/storage/azfile/file/models.go

@@ -124,11 +124,16 @@ func (o *CreateOptions) format() (*generated.FileClientCreateOptions, *generated
 			FilePermissionKey: permissionKey,
 			Metadata:          o.Metadata,
 		}
-
-		if permissionKey != nil && *permissionKey != shared.DefaultFilePermissionString {
-			createOptions.FilePermissionFormat = to.Ptr(PermissionFormat(shared.DefaultFilePermissionFormat))
-		} else if o.FilePermissionFormat != nil {
-			createOptions.FilePermissionFormat = to.Ptr(PermissionFormat(*o.FilePermissionFormat))
+		// Refer the documentation for details - https://learn.microsoft.com/en-us/rest/api/storageservices/create-file#smb-only-request-headers
+		if permissionKey != nil {
+			createOptions.FilePermissionKey = permissionKey
+		} else if permission != nil {
+			createOptions.FilePermission = permission
+			if o.FilePermissionFormat != nil {
+				createOptions.FilePermissionFormat = to.Ptr(*o.FilePermissionFormat)
+			} else {
+				createOptions.FilePermissionFormat = to.Ptr(FilePermissionFormatSddl) // optional, default
+			}
 		}
 	}
 	return createOptions, o.HTTPHeaders, o.LeaseAccessConditions