mgmt, authorization, support description in role assignment (Azure#31596)

Author: weidongxu-microsoft

sdk/resourcemanager/azure-resourcemanager-authorization/CHANGELOG.md

@@ -4,11 +4,7 @@
 
 ### Features Added
 
-### Breaking Changes
-
-### Bugs Fixed
-
-### Other Changes
+- Supported description in role assignment.
 
 ## 2.19.0 (2022-09-23)
 

sdk/resourcemanager/azure-resourcemanager-authorization/pom.xml

@@ -43,6 +43,8 @@
     <javaModulesSurefireArgLine>
       --add-opens com.azure.resourcemanager.authorization/com.azure.resourcemanager.authorization=ALL-UNNAMED
       --add-opens com.azure.resourcemanager.resources/com.azure.resourcemanager.resources=ALL-UNNAMED
+
+      --add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
     </javaModulesSurefireArgLine>
   </properties>
 

sdk/resourcemanager/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/implementation/RoleAssignmentImpl.java

@@ -30,6 +30,7 @@ class RoleAssignmentImpl extends CreatableImpl<RoleAssignment, RoleAssignmentInn
     private String roleDefinitionId;
     private String roleName;
     private String scope;
+    private String description;
     private final ClientLogger logger = new ClientLogger(RoleAssignmentImpl.class);
 
     RoleAssignmentImpl(String name, RoleAssignmentInner innerObject, AuthorizationManager manager) {
@@ -78,7 +79,8 @@ public Mono<RoleAssignment> createResourceAsync() {
                     new RoleAssignmentCreateParameters()
                         .withProperties(new RoleAssignmentProperties()
                             .withPrincipalId(objectId)
-                            .withRoleDefinitionId(roleDefinitionId)))
+                            .withRoleDefinitionId(roleDefinitionId)
+                            .withDescription(description)))
             .flatMap(
                 roleAssignmentPropertiesInner ->
                     manager()
@@ -115,6 +117,11 @@ public String condition() {
         return innerModel().properties().condition();
     }
 
+    @Override
+    public String description() {
+        return innerModel().properties().description();
+    }
+
     @Override
     public RoleAssignmentImpl forObjectId(String objectId) {
         this.objectId = objectId;
@@ -184,6 +191,11 @@ public RoleAssignmentImpl withSubscriptionScope(String subscriptionId) {
         return withScope("/subscriptions/" + subscriptionId);
     }
 
+    @Override
+    public RoleAssignmentImpl withDescription(String description) {
+        this.description = description;
+        return this;
+    }
     @Override
     public String id() {
         return innerModel().id();

sdk/resourcemanager/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/models/RoleAssignment.java

@@ -28,9 +28,22 @@ public interface RoleAssignment
     /** @return the principal ID */
     String principalId();
 
-    /** @return the condition */
+    /**
+     * Gets the condition.
+     * <p>
+     * This is a preview feature.
+     *
+     * @return the condition
+     */
     String condition();
 
+    /**
+     * Gets the description.
+     *
+     * @return the description
+     */
+    String description();
+
     /**************************************************************
      * Fluent interfaces to provision an role assignment
      **************************************************************/
@@ -154,11 +167,22 @@ interface WithScope {
             WithCreate withSubscriptionScope(String subscriptionId);
         }
 
+        /** The stage of role assignment definition allowing specifying the description. */
+        interface WithDescription {
+            /**
+             * Specifies the description.
+             *
+             * @param description the description.
+             * @return the next stage in role assignment definition
+             */
+            WithCreate withDescription(String description);
+        }
+
         /**
          * An role assignment definition with sufficient inputs to create a new role assignment in the cloud, but
          * exposing additional optional inputs to specify.
          */
-        interface WithCreate extends Creatable<RoleAssignment> {
+        interface WithCreate extends Creatable<RoleAssignment>, WithDescription {
         }
     }
 }

sdk/resourcemanager/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/models/RoleAssignmentProperties.java

@@ -25,6 +25,9 @@ public final class RoleAssignmentProperties {
     @JsonProperty(value = "principalId", required = true)
     private String principalId;
 
+    @JsonProperty(value = "description")
+    private String description;
+
     /**
      * Get the roleDefinitionId property: The role definition ID used in the role assignment.
      *
@@ -67,6 +70,26 @@ public RoleAssignmentProperties withPrincipalId(String principalId) {
         return this;
     }
 
+    /**
+     * Get the description property: Description of role assignment.
+     *
+     * @return the description value
+     */
+    public String description() {
+        return description;
+    }
+
+    /**
+     * Set the description property: Description of role assignment.
+     *
+     * @param description the description value to set.
+     * @return the RoleAssignmentPropertiesWithScope object itself.
+     */
+    public RoleAssignmentProperties withDescription(String description) {
+        this.description = description;
+        return this;
+    }
+
     /**
      * Validates the instance.
      *

sdk/resourcemanager/azure-resourcemanager-authorization/src/main/java/com/azure/resourcemanager/authorization/models/RoleAssignmentPropertiesWithScope.java

@@ -37,6 +37,9 @@ public final class RoleAssignmentPropertiesWithScope {
     @JsonProperty(value = "condition")
     private String condition;
 
+    @JsonProperty(value = "description")
+    private String description;
+
     /*
      * Version of the condition. Currently accepted value is '2.0'
      */
@@ -136,6 +139,15 @@ public String conditionVersion() {
         return this.conditionVersion;
     }
 
+    /**
+     * Get the description property: Description of role assignment.
+     *
+     * @return the description value
+     */
+    public String description() {
+        return description;
+    }
+
     /**
      * Set the conditionVersion property: Version of the condition. Currently accepted value is '2.0'.
      *

sdk/resourcemanager/azure-resourcemanager-authorization/src/test/java/com/azure/resourcemanager/authorization/RoleAssignmentTests.java

@@ -33,6 +33,7 @@ public void canCRUDRoleAssignment() throws Exception {
                     .forServicePrincipal(sp)
                     .withBuiltInRole(BuiltInRole.CONTRIBUTOR)
                     .withSubscriptionScope(resourceManager.subscriptionId())
+                    .withDescription("contributor role")
                     .create();
 
             Assertions.assertNotNull(roleAssignment);
@@ -46,6 +47,7 @@ public void canCRUDRoleAssignment() throws Exception {
             Assertions.assertEquals(roleAssignment.scope(), roleAssignment1.scope());
             Assertions.assertEquals(roleAssignment.roleDefinitionId(), roleAssignment1.roleDefinitionId());
             Assertions.assertEquals(roleAssignment.principalId(), roleAssignment1.principalId());
+            Assertions.assertEquals("contributor role", roleAssignment1.description());
         } finally {
             authorizationManager.servicePrincipals().deleteById(sp.id());
             authorizationManager