Refactor completions.spec.ts to use testWithDeployments (Azure#33642)

Author: mikhail

sdk/openai/openai/test/public/completions.spec.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-import { matrix } from "@azure-tools/test-utils-vitest";
 import { describe, beforeEach, it } from "vitest";
 import { createClientsAndDeployments } from "../utils/createClients.js";
 import type { APIVersion } from "../utils/utils.js";
@@ -11,46 +10,43 @@ import { completionsModelsToSkip } from "../utils/models.js";
 import "../../src/types/index.js";
 import type { ClientsAndDeploymentsInfo } from "../utils/types.js";
 
-describe("Legacy Completions", function () {
-  matrix([APIMatrix] as const, async function (apiVersion: APIVersion) {
-    describe(`[${apiVersion}] Client`, () => {
-      let clientsAndDeployments: ClientsAndDeploymentsInfo;
+describe.each(APIMatrix)("Legacy Completions [%s]", function (apiVersion: APIVersion) {
+  let clientsAndDeployments: ClientsAndDeploymentsInfo;
 
-      beforeEach(async () => {
-        clientsAndDeployments = createClientsAndDeployments(
-          apiVersion,
-          { completion: "true" },
-          { clientOptions: { maxRetries: 0 }, deploymentsToSkip: ["computer-use-preview"] },
-        );
-      });
+  beforeEach(async () => {
+    clientsAndDeployments = createClientsAndDeployments(
+      apiVersion,
+      { completion: "true" },
+      { clientOptions: { maxRetries: 0 }, deploymentsToSkip: ["computer-use-preview"] },
+    );
+  });
 
-      describe("completions.create", function () {
-        it("returns completions across all models", async () => {
-          const prompt = ["What is Azure OpenAI?"];
-          await withDeployments(
-            clientsAndDeployments,
-            (client, deploymentName) =>
-              client.completions.create({ model: deploymentName, prompt }),
-            assertCompletions,
-            completionsModelsToSkip,
-          );
-        });
+  describe("completions.create", function () {
+    it("returns completions across all models", async () => {
+      const prompt = ["What is Azure OpenAI?"];
+      await withDeployments(
+        clientsAndDeployments,
+        (client, deploymentName) => client.completions.create({ model: deploymentName, prompt }),
+        assertCompletions,
+        completionsModelsToSkip,
+      );
+    });
 
-        it("returns completions stream", async () => {
-          const prompt = ["This is Azure OpenAI?"];
-          await withDeployments(
-            clientsAndDeployments,
-            (client, deploymentName) =>
-              client.completions.create({ model: deploymentName, prompt, stream: true }),
-            // The API returns an empty choice in the first event for some
-            // reason. This should be fixed in the API.
-            (result) => assertCompletionsStream(result, { allowEmptyChoices: true }),
-          );
-        });
+    it("returns completions stream", async () => {
+      const prompt = ["This is Azure OpenAI?"];
+      await withDeployments(
+        clientsAndDeployments,
+        (client, deploymentName) =>
+          client.completions.create({ model: deploymentName, prompt, stream: true }),
+        // The API returns an empty choice in the first event for some
+        // reason. This should be fixed in the API.
+        (result) => assertCompletionsStream(result, { allowEmptyChoices: true }),
+      );
+    });
 
-        it("stream long completions", async () => {
-          const prompt = [
-            `##### Translate this code snippet into Python. Use Azure SDKs where possible.
+    it("stream long completions", async () => {
+      const prompt = [
+        `##### Translate this code snippet into Python. Use Azure SDKs where possible.
   \`\`\`
   using System.Threading.Tasks;
   using Microsoft.AspNetCore.Mvc;
@@ -104,21 +100,19 @@ describe("Legacy Completions", function () {
   
   \`\`\`
   `,
-          ];
-          await withDeployments(
-            clientsAndDeployments,
-            (client, deploymentName) =>
-              client.completions.create(
-                { model: deploymentName, prompt, stream: true, max_tokens: 2048 },
-                { timeout: 10000 },
-              ),
+      ];
+      await withDeployments(
+        clientsAndDeployments,
+        (client, deploymentName) =>
+          client.completions.create(
+            { model: deploymentName, prompt, stream: true, max_tokens: 2048 },
+            { timeout: 10000 },
+          ),
 
-            // The API returns an empty choice in the first event for some
-            // reason. This should be fixed in the API.
-            (result) => assertCompletionsStream(result, { allowEmptyChoices: true }),
-          );
-        });
-      });
+        // The API returns an empty choice in the first event for some
+        // reason. This should be fixed in the API.
+        (result) => assertCompletionsStream(result, { allowEmptyChoices: true }),
+      );
     });
   });
 });