Skip to content

Commit b1bcf48

Browse files
[ContainerRegistry] Fix RegistryUri of ContainerRegistryImportSource (Azure#31926)
1 parent 9d9f701 commit b1bcf48

7 files changed

+46
-9
lines changed

sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/CHANGELOG.md

+7-5
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
# Release History
22

3-
## 1.1.0-beta.3 (Unreleased)
3+
## 1.1.0-beta.3 (2022-10-21)
44

5-
### Features Added
5+
### Bugs Fixed
66

7-
### Breaking Changes
7+
- Deprecate `RegistryUri` property and replace it with `RegistryAddress` in `ContainerRegistryImportSource`.
88

9-
### Bugs Fixed
9+
## 1.0.2 (2022-10-21)
1010

11-
### Other Changes
11+
### Bug Fixes
12+
13+
- Deprecate `RegistryUri` property and replace it with `RegistryAddress` in `ContainerRegistryImportSource`.
1214

1315
## 1.1.0-beta.2 (2022-09-14)
1416

sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/api/Azure.ResourceManager.ContainerRegistry.netstandard2.0.cs

+3
Original file line numberDiff line numberDiff line change
@@ -1207,6 +1207,9 @@ public partial class ContainerRegistryImportSource
12071207
{
12081208
public ContainerRegistryImportSource(string sourceImage) { }
12091209
public Azure.ResourceManager.ContainerRegistry.Models.ContainerRegistryImportSourceCredentials Credentials { get { throw null; } set { } }
1210+
public string RegistryAddress { get { throw null; } set { } }
1211+
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
1212+
[System.ObsoleteAttribute("RegistryUri is deprecated, use RegistryAddress instead")]
12101213
public System.Uri RegistryUri { get { throw null; } set { } }
12111214
public Azure.Core.ResourceIdentifier ResourceId { get { throw null; } set { } }
12121215
public string SourceImage { get { throw null; } }

sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Azure.ResourceManager.ContainerRegistry.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<PropertyGroup>
33
<Version>1.1.0-beta.3</Version>
44
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
5-
<ApiCompatVersion>1.0.1</ApiCompatVersion>
5+
<ApiCompatVersion>1.0.2</ApiCompatVersion>
66
<PackageId>Azure.ResourceManager.ContainerRegistry</PackageId>
77
<Description>Azure Resource Manager client SDK for Azure resource provider ContainerRegistry</Description>
88
<PackageTags>azure;management;arm;resource manager;containerregistry</PackageTags>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
// Copyright (c) Microsoft Corporation. All rights reserved.
2+
// Licensed under the MIT License.
3+
4+
#nullable disable
5+
6+
using System;
7+
using System.ComponentModel;
8+
9+
namespace Azure.ResourceManager.ContainerRegistry.Models
10+
{
11+
/// <summary> The ContainerRegistryImportSource. </summary>
12+
public partial class ContainerRegistryImportSource
13+
{
14+
/// <summary> The address of the source registry (e.g. &apos;mcr.microsoft.com&apos;). </summary>
15+
[Obsolete("RegistryUri is deprecated, use RegistryAddress instead")]
16+
[EditorBrowsable(EditorBrowsableState.Never)]
17+
public Uri RegistryUri
18+
{
19+
get
20+
{
21+
if (RegistryAddress != null && Uri.TryCreate(RegistryAddress, UriKind.Absolute, out var registryUri))
22+
return registryUri;
23+
return null;
24+
}
25+
set
26+
{
27+
RegistryAddress = value == null ? null : value.AbsoluteUri;
28+
}
29+
}
30+
}
31+
}

sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Generated/Models/ContainerRegistryImportSource.Serialization.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Generated/Models/ContainerRegistryImportSource.cs

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/autorest.md

+1
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ rename-mapping:
237237
ExportPipelineTargetProperties.type: PipelineTargetType
238238
TlsCertificateProperties.location: CertificateLocation
239239
TokenCredentialsProperties: ContainerRegistryTokenCredentials
240+
ImportSource.registryUri: RegistryAddress
240241

241242
override-operation-name:
242243
Schedules_ScheduleRun: ScheduleRun

0 commit comments

Comments
 (0)