Skip to content

Commit 3813a58

Browse files
committed
fix(belgium): correct nationalDay translations and rename PentecostMondayTest
- Capitalise Dutch translation of nationalDay: 'Nationale feestdag' - Add German translation for nationalDay: 'Nationalfeiertag' - Rename pentecostMondayTest -> PentecostMondayTest (file and class) for consistency with all other Belgium test files Signed-off-by: Sacha Telgenhof <me@sachatelgenhof.com>
1 parent a2fafb1 commit 3813a58

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/Yasumi/Provider/Belgium.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,10 @@ public function initialize(): void
6666
* Belgian National Day is the National Day of Belgium celebrated on 21 July each year.
6767
*/
6868
$this->addHoliday(new Holiday('nationalDay', [
69-
'fr' => 'Fête nationale',
69+
'de' => 'Nationalfeiertag',
7070
'en' => 'Belgian National Day',
71-
'nl' => 'nationale feestdag',
71+
'fr' => 'Fête nationale',
72+
'nl' => 'Nationale feestdag',
7273
], new \DateTime("{$this->year}-7-21", DateTimeZoneFactory::getDateTimeZone($this->timezone)), $this->locale));
7374
}
7475

tests/Belgium/NationalDayTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function testTranslation(): void
6565
self::REGION,
6666
self::HOLIDAY,
6767
static::generateRandomYear(),
68-
[self::LOCALE => 'nationale feestdag']
68+
[self::LOCALE => 'Nationale feestdag']
6969
);
7070
}
7171

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
/**
2424
* Class for testing Pentecost Monday in Belgium.
2525
*/
26-
class pentecostMondayTest extends BelgiumBaseTestCase implements HolidayTestCase
26+
class PentecostMondayTest extends BelgiumBaseTestCase implements HolidayTestCase
2727
{
2828
/**
2929
* The name of the holiday to be tested.

0 commit comments

Comments
 (0)