test(slovakia): fix excluded years in data providers

Return false from callbacks in OurLadyOfSorrowsDayTest and
VictoryInEuropeDayTest to properly skip years 2025 and 2026;
previously the bare return had no effect and excluded years
could still appear in the generated test data.

Signed-off-by: Sacha Telgenhof <me@sachatelgenhof.com>

Author: stelgenhof

tests/Randomizer.php

@@ -240,7 +240,10 @@ public function generateRandomDatesWithModifier(
             $year = $this->generateRandomYear($range);
             $date = new \DateTime("{$year}-{$month}-{$day}", new \DateTimeZone($timezone ?? 'UTC'));
 
-            $callback($year, $date);
+            if (false === $callback($year, $date)) {
+                --$i;
+                continue;
+            }
 
             $data[] = [$year, $date->format('Y-m-d')];
         }

tests/Slovakia/OurLadyOfSorrowsDayTest.php

@@ -56,11 +56,13 @@ public function testHoliday(int $year, $expected): void
      */
     public function HolidayDataProvider(): array
     {
-        return $this->generateRandomDatesWithModifier(9, 15, function ($year, \DateTime $date): void {
+        return $this->generateRandomDatesWithModifier(9, 15, function ($year, \DateTime $date): ?bool {
             // Our Lady of Sorrows Day is not observed in 2025 and 2026
             if (in_array($year, [2025, 2026])) {
-                return;
+                return false;
             }
+
+            return null;
         }, 5, 1000, self::TIMEZONE);
     }
 

tests/Slovakia/VictoryInEuropeDayTest.php

@@ -59,11 +59,13 @@ public function testHoliday(int $year, string $expected): void
      */
     public function HolidayDataProvider(): array
     {
-        return $this->generateRandomDatesWithModifier(5, 8, function ($year, \DateTime $date): void {
+        return $this->generateRandomDatesWithModifier(5, 8, function ($year, \DateTime $date): ?bool {
             // Victory in Europe Day is not observed in 2025 and 2026
             if (in_array($year, [2025, 2026])) {
-                return;
+                return false;
             }
+
+            return null;
         }, 5, 1000, self::TIMEZONE);
     }