Plugin fails to load in PocketBook 632

[mikhaeld]

• KOReader: v2024.11
• PB FW: U632.6.8.4078

Starting the plugin ends in failure with "Failed to start Filebrowser".

04/01/25-00:07:28 DEBUG [Filebrowser] Check if Filebrowser is running: start-stop-daemon --pidfile /tmp/filebrowser_koreader.pid --exec /mnt/ext1/applications/koreader/plugins/filebrowser.koplugin/filebrowser/filebrowser -K --test
sh: start-stop-daemon: not found
04/01/25-00:07:28 DEBUG [Filebrowser] Running status exit code (0 -> running): 32512
04/01/25-00:07:28 DEBUG [Filebrowser] Launching Filebrowser: start-stop-daemon -S --make-pidfile --pidfile /tmp/filebrowser_koreader.pid --oknodo --background --exec /mnt/ext1/applications/koreader/plugins/filebrowser.koplugin/filebrowser/filebrowser -- -a 0.0.0.0 -r / -p 80 -l /mnt/ext1/applications/koreader/plugins/filebrowser.koplugin/filebrowser/filebrowser.log
sh: start-stop-daemon: not found

This seems to be caused from a missing command "start-stop-daemon" which is not included in the BusyBox implementation from PocketBook Linux distribution

BusyBox v1.26.2 (2022-10-28 08:15:54 UTC) multi-call binary.
BusyBox is copyrighted by many authors between 1998-2015.
Licensed under GPLv2. See source distribution for detailed
copyright notices.

Usage: busybox [function [arguments]...]
or: busybox --list
or: function [arguments]...

    BusyBox is a multi-call binary that combines many common Unix
    utilities into a single executable.  Most people will create a
    link to busybox for each function they wish to use and BusyBox
    will act like whatever it was invoked as.

Currently defined functions:
[, [[, ar, arp, arping, ash, awk, base64, basename, blkdiscard, blkid,
bunzip2, bzcat, bzip2, cat, catv, chattr, chgrp, chmod, chown, chroot,
chrt, cksum, clear, cmp, conspy, cp, cpio, cut, date, dc, dd, devmem,
df, dhcprelay, diff, dirname, dmesg, dnsdomainname, dos2unix, du,
dumpkmap, dumpleases, echo, egrep, env, expr, false, fatattr, fdflush,
fdisk, fgrep, find, flock, fold, free, freeramdisk, fsck, fstrim,
fsync, fuser, getopt, getty, grep, gunzip, gzip, halt, hd, hdparm,
head, hexdump, hostname, hwclock, i2cdetect, i2cdump, i2cget, i2cset,
id, ifconfig, ifdown, ifup, init, insmod, ionice, iostat, ipcrm, ipcs,
kill, killall, killall5, klogd, last, less, linux32, linuxrc, ln,
logger, login, logname, losetup, ls, lsattr, lsmod, lsof, lsusb, lzcat,
lzma, lzopcat, makedevs, md5sum, mdev, mesg, mkdir, mkdosfs, mke2fs,
mkfifo, mkfs.ext2, mkfs.vfat, mknod, mkpasswd, mkswap, mktemp,
modprobe, more, mount, mountpoint, mv, nc, netstat, nice, nohup,
nsenter, nslookup, od, passwd, patch, pgrep, pidof, ping, pivot_root,
pkill, poweroff, printenv, printf, ps, pstree, pwd, readahead,
readlink, readprofile, realpath, reboot, renice, reset, resize, rm,
rmdir, rmmod, route, runlevel, sed, seq, setarch, setserial, setsid,
sh, sha1sum, sha256sum, sha3sum, sha512sum, sleep, sort, split, stat,
strings, stty, su, svc, swapoff, swapon, switch_root, sync, sysctl,
syslogd, tail, tar, tee, test, time, timeout, top, touch, tr,
traceroute, true, truncate, tty, tune2fs, ubirename, udhcpc, udhcpd,
uevent, umount, uname, uncompress, uniq, unix2dos, unlink, unlzma,
unlzop, unshare, unxz, unzip, uptime, usleep, uudecode, uuencode, vi,
watch, watchdog, wc, which, xargs, xz, xzcat, yes, zcat

[b-]

Huh, that's interesting! And I'm sorry for not replying to this sooner -- I think I missed the email notification.

I mostly ripped code from the SSH server daemon to make this plugin, so could you please just confirm to me that the Pocketbook version of KOreader comes with the SSH server (and that it functions)? I'll try to see if they do anything special on that version…

(I don't have a Pocketbook myself to test on!)

I wonder if bundling a static binary of Busybox itself would help. I could maybe make a special version for some devices.

Thanks for the report!

EDIT: I am noticing the little "forked from" indicator and remembering that actually I ripped this code from the SyncThing plugin, which itself seemed to have been forked from an older version of the SSH plugin.

I definitely will look at the SSH plugin again, because chances are they found and fixed this bug there…

[kaporjan]

I managed to have it running on PocketBook ERA (monochrome) .
I guess it is similar on other PocketBook devices.

The main.lua file needs a little modification because:

• PocketBook firmware doesn’t let user processes (like KOReader plugins) bind to privileged ports (below 1024). Port 80 is reserved, so the binary silently failed to listen. By moving it to 8080, you’re in the safe, unprivileged range and everything works normally.
• PocketBook firmware doesn’t include start-stop-daemon.

This script will use 8080 port and no start-stop-daemon to run:

`
local DataStorage = require("datastorage")
local Device = require("device")
local Dispatcher = require("dispatcher")
local InfoMessage = require("ui/widget/infomessage")
local UIManager = require("ui/uimanager")
local WidgetContainer = require("ui/widget/container/widgetcontainer")
local ffiutil = require("ffi/util")
local logger = require("logger")
local util = require("util")
local _ = require("gettext")

local dataPath = "/"
local path = DataStorage:getFullDataDir()
local plugin_path = path .. "/plugins/filebrowser.koplugin/filebrowser"
local config_path = path .. "/plugins/filebrowser.koplugin/config.json"
local db_path = path .. "/plugins/filebrowser.koplugin/filebrowser-new.db"
local bin_path = plugin_path .. "/filebrowser"
local filebrowser_args = string.format("-d %s -c %s ", db_path, config_path)
local filebrowser_cmd = bin_path .. " " .. filebrowser_args
local log_path = plugin_path .. "/filebrowser.log"
local pid_path = "/tmp/filebrowser_koreader.pid"

local silence_cmd = " >/dev/null 2>&1"

if not util.pathExists(bin_path) then
logger.info("[Filebrowser] filebrowser binary missing, plugin not loading")
return { disabled = true, }
end

local Filebrowser = WidgetContainer:extend {
name = "Filebrowser",
is_doc_only = false,
}

function Filebrowser:init()
self.filebrowser_port = G_reader_settings:readSetting("filebrowser_port") or "8080"
self.filebrowser_password_hash = G_reader_settings:readSetting("filebrowser_password") or "admin"
self.ui.menu:registerToMainMenu(self)
self:onDispatcherRegisterActions()
end

function Filebrowser:config()
os.remove(config_path)
os.remove(db_path)

local init_cmd = filebrowser_cmd .. " config init" .. silence_cmd
logger.dbg("init:", init_cmd)
local status = os.execute(init_cmd)

local add_user_cmd = filebrowser_cmd .. "users add koreader koreader123456789 --perm.admin" .. silence_cmd
logger.dbg("create_user:", add_user_cmd)
status = os.execute(add_user_cmd)
logger.dbg("status:", status)

local disable_auth_cmd = string.format("%s -d %s -c %s config set --auth.method=noauth", bin_path, db_path, config_path) .. silence_cmd
logger.dbg("set_noauth:", disable_auth_cmd)
status = status + os.execute(disable_auth_cmd)
logger.dbg("status:", status)

if status == 0 then
    logger.info("[Filebrowser] User 'koreader' has been created and auth has been disabled.")
else
    logger.info("[Filebrowser] Failed to reset admin password and auth, status:", status)
    local info = InfoMessage:new {
        icon = "notice-warning",
        text = _("Failed to reset Filebrowser config."),
    }
    UIManager:show(info)
end

end

-- Start filebrowser directly in background and save PID
function Filebrowser:start()
if not util.fileExists(db_path) then
self:config()
end

local cmd = string.format("%s %s -a 0.0.0.0 -r %s -p %s -l %s %s & echo $! > %s",
    bin_path, filebrowser_args, dataPath, self.filebrowser_port, log_path, silence_cmd, pid_path)

logger.info("[Filebrowser] Launching Filebrowser:", cmd)
local status = os.execute(cmd)

if status == 0 then
    logger.info("[Filebrowser] Filebrowser started. Find Filebrowser logs at", log_path)
    local info = InfoMessage:new {
        timeout = 2,
        text = _("Filebrowser started!")
    }
    UIManager:show(info)
else
    logger.info("[Filebrowser] Failed to start Filebrowser, status:", status)
    local info = InfoMessage:new {
        icon = "notice-warning",
        text = _("Failed to start Filebrowser."),
    }
    UIManager:show(info)
end

end

-- Check if running by looking for PID
function Filebrowser:isRunning()
local f = io.open(pid_path, "r")
if not f then
return false
end
local pid = f:read("*l")
f:close()
if not pid or pid == "" then
return false
end
local status = os.execute("kill -0 " .. pid .. silence_cmd)
return status == 0
end

-- Stop by killing saved PID
function Filebrowser:stop()
local f = io.open(pid_path, "r")
if not f then
logger.info("[Filebrowser] No PID file found, nothing to stop")
return
end
local pid = f:read("*l")
f:close()

if pid and pid ~= "" then
    local cmd = "kill " .. pid .. silence_cmd
    logger.info("[Filebrowser] Stopping Filebrowser:", cmd)
    local status = os.execute(cmd)
    if status == 0 then
        logger.info("[Filebrowser] Filebrowser stopped.")
        UIManager:show(InfoMessage:new {
            text = _("Filebrowser stopped!"),
            timeout = 2,
        })
        os.remove(pid_path)
    else
        logger.info("[Filebrowser] Failed to stop Filebrowser, status:", status)
        UIManager:show(InfoMessage:new {
            icon = "notice-warning",
            text = _("Failed to stop Filebrowser."),
        })
    end
end

end

function Filebrowser:onToggleFilebrowser()
if self:isRunning() then
self:stop()
else
self:start()
end
end

function Filebrowser:addToMainMenu(menu_items)
menu_items.filebrowser = {
text = _("Filebrowser"),
sorting_hint = "network",
keep_menu_open = true,
checked_func = function() return self:isRunning() end,
callback = function(touchmenu_instance)
self:onToggleFilebrowser()
ffiutil.sleep(1)
touchmenu_instance:updateItems()
end,
}
end

function Filebrowser:onDispatcherRegisterActions()
Dispatcher:registerAction("toggle_filebrowser", {
category = "none",
event = "ToggleFilebrowser",
title = _("Toggle Filebrowser"),
general = true
})
end

return Filebrowser

`