PX4-Autopilot/.github/workflows/clang-tidy.yml at main · b-rnab/PX4-Autopilot · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
name: Static Analysis

on:
  push:
    branches:
    - 'main'
    paths-ignore:
      - 'docs/**'
  pull_request:
    branches:
      - '**'
    paths-ignore:
      - 'docs/**'

permissions:
  contents: read

jobs:
  clang_tidy:
    name: Clang-Tidy
    runs-on: [runs-on, runner=16cpu-linux-x64, "run-id=${{ github.run_id }}", "extras=s3-cache"]
    container:
      image: ghcr.io/px4/px4-dev:v1.17.0-rc2
    permissions:
      contents: read
      pull-requests: read
    steps:
    - uses: runs-on/action@v2
    - uses: actions/checkout@v6
      with:
        fetch-depth: 0
        fetch-tags: true

    - name: Configure Git Safe Directory
      run: git config --system --add safe.directory '*'

    - uses: ./.github/actions/setup-ccache
      id: ccache
      with:
        cache-key-prefix: ccache-clang-tidy
        max-size: 150M

    - name: Build - px4_sitl_default (Clang)
      run: make -j16 px4_sitl_default-clang

    - name: Run Clang-Tidy Analysis
      id: clang_tidy
      run: |
        if [ "${{ github.event_name }}" != "pull_request" ]; then
          make -j$(nproc) clang-tidy
        else
          python3 Tools/ci/run-clang-tidy-pr.py origin/${{ github.base_ref }}
        fi

    # On PRs, also produce a `pr-review` artifact for the PR Review Poster
    # workflow to consume. clang-tidy-diff-18 emits a unified fixes.yml that
    # the producer script translates into line-anchored review comments.
    # Running this inside the same container as the build means there is no
    # workspace-path rewriting and no cross-runner artifact handoff.
    - name: Export clang-tidy fixes for PR review
      if: always() && github.event_name == 'pull_request'
      run: |
        mkdir -p pr-review
        git diff -U0 origin/${{ github.base_ref }}...HEAD \
          | clang-tidy-diff-18.py -p1 \
              -path build/px4_sitl_default-clang \
              -export-fixes pr-review/fixes.yml \
              -j0 || true

    - name: Build pr-review artifact
      if: always() && github.event_name == 'pull_request'
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: |
        python3 Tools/ci/clang-tidy-fixes-to-review.py \
          --fixes pr-review/fixes.yml \
          --repo-root "$GITHUB_WORKSPACE" \
          --repo "$GITHUB_REPOSITORY" \
          --pr-number "${{ github.event.pull_request.number }}" \
          --commit-sha "${{ github.event.pull_request.head.sha }}" \
          --out-dir pr-review \
          --event REQUEST_CHANGES

    - name: Upload pr-review artifact
      if: always() && github.event_name == 'pull_request'
      uses: actions/upload-artifact@v7
      with:
        name: pr-review
        path: |
          pr-review/manifest.json
          pr-review/comments.json
        retention-days: 1

    - uses: ./.github/actions/save-ccache
      if: always()
      with:
        cache-primary-key: ${{ steps.ccache.outputs.cache-primary-key }}