includeFloating elements missing in alternate languages

[Narfsn]

Using container with tt_content CType shortcut elements in an alternate language allows the selection of translated containers in the alternate language. The shortcut itself handles those cases by falling back to the default language and applying the overlay. Thus the container element itself is rendered, but it fails to find the child elements.

Container versions: ^3.1.2
TYPO3: ^12.4 & ^13.4

Language Configuration:

languages:
  -
    title: Deutsch
    enabled: true
    base: /de/
    typo3Language: de
    locale: de_DE.UTF-8
    iso-639-1: de
    navigationTitle: Deutsch
    hreflang: de
    direction: ltr
    flag: de
    languageId: 0
  -
    title: Englisch
    enabled: true
    base: /en/
    typo3Language: default
    locale: en_US.UTF-8
    iso-639-1: en
    navigationTitle: ''
    hreflang: en-US
    direction: ''
    fallbackType: strict
    fallbacks: ''
    flag: us
    languageId: 2

This used to work until 3.1.2 and the removal of B13\Container\Domain\Factory\PageView\Frontend\ContainerFactory::doOverlay() due to #575.

Content childs of the container are using the default language container uid as tx_container_parent if the parent container is a translation.
The new B13\Container\Domain\Factory\FrontendContainerFactory only applies the l18n parent on LanguageAspect::OVERLAYS_OFF (Which would be fallbackType: free).

See:

container/Classes/Domain/Factory/FrontendContainerFactory.php

Line 46 in 11b9024

$conf = ['where' => 'tx_container_parent=' . $record['uid'], 'orderBy' => 'sorting', 'pidInList' => $record['pid']];

public function buildContainer(ContentObjectRenderer $cObj, Context $context, ?int $uid = null): Container
{
    [...]
    if ($languageAspect->getOverlayType() === LanguageAspect::OVERLAYS_OFF && $record['l18n_parent'] > 0) {
        $conf['where'] .= ' OR tx_container_parent=' . $record['l18n_parent'];
    }
    [...]
}

The above configuration results in something like LanguageAspect::OVERLAYS_ON_WITH_FLOATING which is afaik the default behavior.
I'm not entirely sure if the support was intentionally droped, but the change below would result in the content elements being displayed again:

public function buildContainer(ContentObjectRenderer $cObj, Context $context, ?int $uid = null): Container
{
    [...]
    if ($languageAspect->getOverlayType() === LanguageAspect::OVERLAYS_OFF || ($languageAspect->getOverlayType() === LanguageAspect::OVERLAYS_ON_WITH_FLOATING) && $record['l18n_parent'] > 0) {
        $conf['where'] .= ' OR tx_container_parent=' . $record['l18n_parent'];
    }
    [...]
}

Hope my description is somewhat understandable. I can provide a sample project if necessary.

[achimfritz]

Hi @Narfsn , can you build a page with (minimal) tt_content elements that shows the behaviour? and attach select uid,pid,CType,header,colPos,tx_container_parent,sys_language_uid,l18n_parent where pid=<my-page-id> to the issue.
This would help me to understand your setup,

[Narfsn]

Hi @achimfritz, thanks for having a look at it!
A minimal setup to reproduce it involves the shortcut element, so i just rebuilt that and added the records row.

Container Setup

The container by itself on pid 1 works fine, as it's generated by the translation process in the backend.

Shortcut Setup

I created some shortcuts on pid 2: But as you can see i modified the english variant to use the UID of the translation (3). In the backend everything works fine, the translated content of container 3 is displayed. In the Frontend (uid=2&L=2) only the default language container will have content. The translated page will only render the container, but not it's child.

uid	pid	CType	header	colPos	tx_container_parent	sys_language_uid	l18n_parent	records
1	1	container-box	Default Container	0	0	0	0	NULL
2	1	text	Default Container Child	100	1	0	0	NULL
3	1	container-box	Translated Container	0	0	2	1	NULL
4	1	text	Translated Container Child	100	1	2	2	NULL
5	2	shortcut	Default Shortcut	0	0	0	0	1
6	2	shortcut	Translated Shortcut	0	0	2	5	3

As you can see, the translated container child (4) points to tx_container_parent 1 which then causes the FrontendContainerFactory to not find anything, if we directly render content uid 3.

Mind you, this is not the default behavior of a translation created from the translation process, but rather a thing most editors somehow seem to do. A regular translation process of the shortcut will point to the original tt_content entry. So basically 1 in both records rows. This still works in module/web/ context it will only fail on uid=2&L=2 due to the container being rendered as a floating element.

Frontend Links

This would be PID 2 with the shortcut elements, alternate language is not working:
Alternate: https://container-typo3-13.pdcdn.de/en/alternate-language-shortcut
Default: https://container-typo3-13.pdcdn.de/default-shortcut