[BUGFIX] nullable type declaration

addition: CI should fail on cgl fail

Author: achimfritz

.gitignore

@@ -1,6 +1,7 @@
 public
 composer.lock
 vendor
+var
 .php_cs.cache
 .php-cs-fixer.cache
 /.Build

Build/php-cs-fixer.php

@@ -1,6 +1,11 @@
 <?php
 
 $config = \TYPO3\CodingStandards\CsFixerConfig::create();
-$config->getFinder()->in(['Classes', 'Configuration']);
-$config->getFinder()->exclude(['var', 'public']);
+$config->getFinder()->exclude(['var', 'public', 'Build'])->in(__DIR__ . '/..');
+$config->addRules([
+    'nullable_type_declaration' => [
+        'syntax' => 'question_mark',
+    ],
+    'nullable_type_declaration_for_default_null_value' => true,
+]);
 return $config;

Build/testing-docker/docker-compose.yml

@@ -15,7 +15,7 @@ services:
           set -x
         fi
         php -v | grep '^PHP';
-        ${CORE_ROOT}/.Build/bin/php-cs-fixer fix --config Build/php-cs-fixer.php
+        ${CORE_ROOT}/.Build/bin/php-cs-fixer fix --config Build/php-cs-fixer.php --dry-run --stop-on-violation --using-cache=no
       "
 
   composer_update:

Classes/Command/CollectGarbageCommand.php

@@ -23,7 +23,7 @@ final class CollectGarbageCommand extends Command
 {
     public function __construct(
         private readonly JobRepository $jobRepository,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

Classes/Command/JobCreatorCommand.php

@@ -30,7 +30,7 @@ public function __construct(
         private readonly ExtensionConfiguration $extensionConfiguration,
         private readonly ConfigurationValidator $validator,
         private readonly JobRepository $jobRepository,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

Classes/Command/JobKillerCommand.php

@@ -23,7 +23,7 @@ final class JobKillerCommand extends Command
 {
     public function __construct(
         private readonly JobRepository $jobRepository,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

Classes/Command/RunnerCommand.php

@@ -28,7 +28,7 @@ public function __construct(
         private readonly ProcessRunner $processRunner,
         private readonly JobRepository $jobRepository,
         private readonly ConfigurationValidator $validator,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

Classes/Command/StatusReportCommand.php

@@ -25,7 +25,7 @@ class StatusReportCommand extends Command
 {
     public function __construct(
         private readonly StatusReportFactory $statusReportFactory,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

Classes/Domain/Model/Job.php

@@ -90,7 +90,7 @@ public function toDatabaseRow(): array
             'json_configuration' => $json,
             'created_time' => $this->createdTime->format('U'),
             'start_time' => $this->startTime ? $this->startTime->format('U') : 0,
-            'end_time' => $this->endTime ? $this->endTime->format('U'): 0,
+            'end_time' => $this->endTime ? $this->endTime->format('U') : 0,
             'error' => $this->error,
         ];
     }

Classes/Event/BeforeProcessRunnerExecutesCommandsEvent.php

@@ -18,7 +18,7 @@ final class BeforeProcessRunnerExecutesCommandsEvent
 {
     public int $timeoutPerProcess = 60;
 
-    public function  __construct(
+    public function __construct(
         public readonly Configuration $configuration,
         public array $commands
     ) {}