[TASK] use constants for commands return

Author: achimfritz

Classes/Command/CollectGarbageCommand.php

@@ -35,6 +35,6 @@ public function execute(InputInterface $input, OutputInterface $output): int
             $job->fail('job too old');
             $this->jobRepository->updateJob($job);
         }
-        return 0;
+        return Command::SUCCESS;
     }
 }

Classes/Command/JobCreatorCommand.php

@@ -47,6 +47,6 @@ public function execute(InputInterface $input, OutputInterface $output): int
             $output->writeln($e->getMessage());
             return Command::FAILURE;
         }
-        return 0;
+        return Command::SUCCESS;
     }
 }

Classes/Command/JobKillerCommand.php

@@ -32,10 +32,10 @@ public function execute(InputInterface $input, OutputInterface $output): int
     {
         $job = $this->jobRepository->findOneLast();
         if ($job === null) {
-            return 0;
+            return Command::SUCCESS;
         }
         $job->kill();
         $this->jobRepository->updateJob($job);
-        return 0;
+        return Command::SUCCESS;
     }
 }

Classes/Command/RunnerCommand.php

@@ -37,11 +37,11 @@ public function execute(InputInterface $input, OutputInterface $output): int
     {
         $runningJob = $this->jobRepository->findOneRunning();
         if ($runningJob !== null) {
-            return 0;
+            return Command::SUCCESS;
         }
         $job = $this->jobRepository->findOneWaiting();
         if ($job === null) {
-            return 0;
+            return Command::SUCCESS;
         }
         $job->start();
         $this->jobRepository->updateJob($job);
@@ -57,11 +57,11 @@ public function execute(InputInterface $input, OutputInterface $output): int
             // @extensionScannerIgnoreLine
             $job->finish();
             $this->jobRepository->updateJob($job);
-            return 0;
+            return Command::SUCCESS;
         } catch (Exception $e) {
             $job->fail($e->getCode() . ' - ' . $e->getMessage());
             $this->jobRepository->updateJob($job);
-            return 1;
+            return Command::FAILURE;
         }
     }
 }

Classes/Command/StatusReportCommand.php

@@ -89,6 +89,6 @@ public function execute(InputInterface $input, OutputInterface $output): int
         } else {
             $output->writeln(LocalizationUtility::translate($llPrefix . 'no-jobs'));
         }
-        return 0;
+        return Command::SUCCESS;
     }
 }