Skip to content

Commit e761acf

Browse files
committed
404 if query does not exist
1 parent 7b90166 commit e761acf

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

b4mad_racing_website/views.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
from django.contrib import messages
66
from django.contrib.auth.mixins import LoginRequiredMixin
7+
from django.db.models import Q
78
from django.forms.models import BaseModelForm
89
from django.http import Http404, HttpResponse, HttpResponseNotAllowed, JsonResponse
910
from django.shortcuts import get_object_or_404, redirect, render
@@ -12,8 +13,6 @@
1213
from django.views.generic.detail import DetailView
1314
from django.views.generic.edit import UpdateView
1415
from django.views.generic.list import ListView
15-
from django.db.models import Q
16-
from django.shortcuts import get_object_or_404
1716

1817
# we need to import these to make sure the apps are registered
1918
import b4mad_racing_website.fastlap_app # noqa: F401
@@ -275,15 +274,17 @@ def sessions(request, template_name="sessions.html", **kwargs):
275274

276275
sessions = []
277276
filter = {}
277+
278+
# Check existence and 404 if not found
278279
if game_id:
280+
context["game"] = get_object_or_404(Game, pk=game_id)
279281
filter["game_id"] = game_id
280-
context["game"] = Game.objects.get(pk=game_id)
281282
if car_id:
283+
context["car"] = get_object_or_404(Car, pk=car_id)
282284
filter["laps__car_id"] = car_id
283-
context["car"] = Car.objects.get(pk=car_id)
284285
if track_id:
286+
context["track"] = get_object_or_404(Track, pk=track_id)
285287
filter["laps__track_id"] = track_id
286-
context["track"] = Track.objects.get(pk=track_id)
287288

288289
# Calculate the start date based on the range
289290
start_date = datetime.now() - timedelta(days=365)

0 commit comments

Comments
 (0)