Skip to content

Commit 3d586d3

Browse files
committed
Remove warnings
1 parent dcd7516 commit 3d586d3

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

Diff for: CMakeLists.txt

+6
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,12 @@ else()
160160
set ( CMAKE_C_FLAGS_RELWITHDEBINFO "${CMAKE_C_FLAGS_RELEASE} -g3")
161161
set ( CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_C_FLAGS_RELWITHDEBINFO}")
162162
set ( CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO "${CMAKE_EXE_LINKER_FLAGS_RELEASE}" )
163+
164+
if (APPLE)
165+
set ( CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Wno-unqualified-std-cast-call" )
166+
set ( CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -Wno-unqualified-std-cast-call" )
167+
set ( CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO} -Wno-unqualified-std-cast-call" )
168+
endif()
163169
endif()
164170

165171
if (KIWI_CPU_ARCH MATCHES "x86_64")

Diff for: src/Combiner.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,7 @@ void RuleSet::loadRules(istream& istr)
780780
while (getline(istr, line))
781781
{
782782
if (line[0] == '#') continue;
783-
while (!line.empty() && line.back() < 0x80 && isSpace(line.back())) line.pop_back();
783+
while (!line.empty() && ((uint8_t)line.back() < 0x80) && isSpace(line.back())) line.pop_back();
784784
if (line.empty()) continue;
785785

786786
auto fields = split(line, '\t');

Diff for: src/sais/mp_utils.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ namespace mp
396396
ThreadPool* pool;
397397
public:
398398
OverrideLimitedSize(ThreadPool* _pool, size_t newSize)
399-
: pool{ _pool }, prevSize{ pool ? pool->limitedSize() : -1 }
399+
: pool{ _pool }, prevSize{ _pool ? _pool->limitedSize() : -1 }
400400
{
401401
if (pool) pool->_limitedSize = newSize;
402402
}

Diff for: test/test_cpp.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ TEST(KiwiCpp, HSDataset)
432432
{
433433
size_t totalBatchCnt = 0, totalTokenCnt = 0, s;
434434
dataset.reset();
435-
while (s = dataset.next(in.data(), out.data(), lmLProbs.data(), outNgramBase.data(), restLm, restLmCnt))
435+
while ((s = dataset.next(in.data(), out.data(), lmLProbs.data(), outNgramBase.data(), restLm, restLmCnt)))
436436
{
437437
EXPECT_LE(s, batchSize);
438438
totalTokenCnt += s;
@@ -456,7 +456,7 @@ TEST(KiwiCpp, HSDataset)
456456
{
457457
size_t totalBatchCnt = 0, totalTokenCnt = 0, s;
458458
trainset.reset();
459-
while (s = trainset.next(in.data(), out.data(), lmLProbs.data(), outNgramBase.data(), restLm, restLmCnt))
459+
while ((s = trainset.next(in.data(), out.data(), lmLProbs.data(), outNgramBase.data(), restLm, restLmCnt)))
460460
{
461461
EXPECT_LE(s, batchSize);
462462
totalTokenCnt += s;
@@ -468,7 +468,7 @@ TEST(KiwiCpp, HSDataset)
468468
{
469469
size_t totalBatchCnt = 0, totalTokenCnt = 0, s;
470470
devset.reset();
471-
while (s = devset.next(in.data(), out.data(), lmLProbs.data(), outNgramBase.data(), restLm, restLmCnt))
471+
while ((s = devset.next(in.data(), out.data(), lmLProbs.data(), outNgramBase.data(), restLm, restLmCnt)))
472472
{
473473
EXPECT_LE(s, batchSize);
474474
totalTokenCnt += s;

0 commit comments

Comments
 (0)