Ensure draft revision functionality matches previous functionality

[herbdool]

We're attempting to not have a dependency on drafty module and seems to be going ok. This is likely because "forward revisions" was introduced to Backdrop previously. Need to decide what to do with the is_draft_revision property that drafty used. Might not need it.

But need to ensure a new revision is capable of saving as a draft aka unpublished, which currently isn't working. And need to make sure if draft/unpublished happens regardless of the default status on the content type ("Publish immediately", "Save as draft", "Schedule for later")

[laryn]

For reference, here's the commit that introduced inactive forward revisions in core: backdrop/backdrop@c645dfb

[laryn]

@herbdool This section from one of the tests is relevant:

    // Save this as a non-active revision.
    $new_node_revision->revision = TRUE;
    $new_node_revision->is_active_revision = FALSE;
    node_save($new_node_revision);

[laryn]

Short form, it looks like we can use the inverse: instead of Drafty's is_draft_revision (TRUE) we'd use the core is_active_revision (FALSE). Right?

[juanolalla]

I've been manually testing this and I can see once the node is published, new drafts revisions are created as published (status=1) in the database, and the revision linked in the node table is that last one draft (also status=1 in that table).

If I manually change in the database the status of the revision to 0, and the table node row to point to the previous published revision, now it works as expected:

1. For anonymous the node view shows the latest published revision
2. For editor, the node view shows the latest published revision, but the view draft and edit draft tab shows the latest draft revision (non published).

[herbdool]

I've added @laryn's suggestion to my previous WIP and it surprisingly now seems to be mostly working. Want to take a look at #3 @juanolalla?

[herbdool]

@juanolalla I had included some of the functionality of Drafty module https://git.drupalcode.org/project/drafty/-/blob/7.x-1.x/drafty.module?ref_type=heads. I had last worked on it last summer so I'm not sure now why I had only included some of it. (See content_moderation_get_published_revision_id() and content_moderation_set_revision_to_be_published). And I'm not sure if we need any of it, or more of it. :) So we'll see.