Download icon on project page replaced with empty square in new design

[bugfolder]

Here's what a download used to look like on a project page (e.g., https://backdropcms.org/project/ubercart):

Here's what it looks like now:

The empty square is a bit puzzling (perhaps unintended?).

Using Safari on Mac, OS X Sequoia. It's also this way in Chrome. Firefox shows something different, but still not as good as a down-arrow:

[argiepiano]

I can confirm this. I noticed it yesterday while exploring the new site.

[bugfolder]

It's because that icon is a FontAwesome character. In the old theme, FontAwesome was included in function borg_preprocess_page():

  // Add FontAwesome.
  backdrop_add_js('https://use.fontawesome.com/baf3c35582.js', array('type' => 'external'));

But in the new theme, that line is commented out and something called "ForkAwesome" is added:

  // Add FontAwesome.
  //$font_awesome = 'https://use.fontawesome.com/baf3c35582.js';
  //backdrop_add_js($font_awesome, array('type' => 'external'));

  // Add ForkAwesome. @todo - replace with ICON API
  $fork_awesome = 'https://cdn.jsdelivr.net/npm/fork-awesome@1.2.0/css/fork-awesome.min.css';
  $attributes = array(
    'integrity' => 'sha256-XoaMnoYC5TH6/+ihMEnospgm0J1PM/nioxbOUdnM8HY=',
    'crossorigin' => 'anonymous',
  );
  backdrop_add_css($fork_awesome, array('type' => 'external', 'attributes' => $attributes));

As the TODO says, perhaps it would be better to use core icons anyhow.

[indigoxela]

...perhaps it would be better to use core icons anyhow.

Like arrow-circle-down-fill.svg 😀

[jenlampton]

I'm not seeing this problem anymore?

[irinaz]

I saw this problem this morning.

[jenlampton]

Well the source code still says it's font awesome, so I'll switch it over to Icon API anyway -- the new theme is doing that everywhere else. :)

[argiepiano]

I'm still seeing the empty square.

[bugfolder]

Flushed all caches, including browser cache, still seeing this:

[jenlampton]

I have just deployed the update. I'm seeing the new icon now.

I don't know why I could see the FontAwesome icon and no one else could -- @quicksketch thought maybe I have FontAwesome as a system font on my computer or something? I'm going to investigate that now...

[bugfolder]

LGTM!

[quicksketch]

All projects seem to be using the new icon except the Backdrop core project itself: https://backdropcms.org/project/backdrop

I'm getting a solid purple square, it seems like the icon is not defined in the CSS.