Contrib Group Application:

[victoralexandrov]

Hello and welcome to the contrib application process! We're happy to have you :)

Please indicate how you intend to help the Backdrop community by joining this group

• Option 1: I would like to contribute a project

Based on your selection above, please provide the following information:

(option 1) The name of your module, theme, or layout
Webform Component Roles

(option 1) Please note these 3 requirements for new contrib projects:

• Include a README.md file containing license and maintainer information.
  You can use this example: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/README.md
• Include a LICENSE.txt file.
  You can use this example: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/LICENSE.txt.
• If porting a Drupal 7 project, Maintain the Git history from Drupal.

(option 1 -- optional) Post a link here to an issue in the drupal.org queue notifying the Drupal 7 maintainers that you are working on a Backdrop port of their project
https://www.drupal.org/project/webform_component_roles/issues/3606878

Post a link to your new Backdrop project under your own GitHub account (option 1)
https://github.com/victoralexandrov/webform_component_roles

If you have chosen option 2 or 1 above, do you agree to the Backdrop Contributed Project Agreement
YES

[quicksketch]

Welcome @victoralexandrov! Thank you for opening an application! I'll take a look shortly.

[herbdool]

I did a cursory review. It looks pretty good. Nothing stood out that is required to change before approving. Though I do have an optional suggestion. In the README you don't need to have a section with a table of the code differences between the Drupal 7 and Backdrop version. That might confuse most admins and developers who are interested can read the code.

Overall, though, it looks good! @victoralexandrov

[quicksketch]

@victoralexandrov I took a look at the module, nice job! There is a requirement when porting modules to maintain the git history from the original module.

If porting a Drupal 7 project, Maintain the Git history from Drupal.

Looks like that has not been done here. Maintaining the history is important for copyright reasons, that the original author holds the copyright and that helps strengthen the "copyleft" rules of the GPL.

This article has some help on how to maintain git history. What I would do here is probably something like this:

1. git clone from the Drupal repository.
2. git checkout 7.x-1.x (or whatever the Drupal branch was).
3. git checkout -b 1.x-1.x to make the Backdrop branch.
4. Copy all your changes for the Backdrop version over the top by copying from your new project.
5. git commit -m "Initial port to Backdrop CMS."
6. Add your current repository as a remote git remote add victoralexandrov git@github.com:victoralexandrov/webform_component_roles.git
7. git push victoralexandrov 1.x-1.x -f Force push and overwrite the repository with the new one that has a full git history.

At that point, you'll have the https://github.com/victoralexandrov/webform_component_roles repository with a single branch and all the Drupal history. Because you don't want any of the other branches from Drupal, at that point I would delete your fork from Drupal (or move it out of the way), and do a fresh git clone from your GitHub copy.

[victoralexandrov]

Thanks for taking the time to guide me through this.

• I cloned the Drupal project
• made a new branch
• copied all my changes
• committed the branch
• edited the README to remove the drupal/backdrop technical differences

Now the repository should have the drupal history.

Please check it out and let me know if I did everything right. Thanks in advance!