enable list deprecations for workspace and resolve existing

Signed-off-by: Kurt King <[email protected]>

Author: kurtaking

workspaces/newrelic/.changeset/famous-terms-jog.md

@@ -0,0 +1,5 @@
+---
+'@backstage-community/plugin-newrelic-dashboard': minor
+---
+
+Removes all existing deprecation notices. If you are still using `DashboardSnapshotComponent`, this will be a breaking change.

workspaces/newrelic/bcp.json

@@ -1,4 +1,5 @@
 {
   "autoVersionBump": true,
-  "knipReports": false
+  "knipReports": false,
+  "listDeprecations": true
 }

workspaces/newrelic/plugins/newrelic-dashboard/report.api.md

@@ -15,13 +15,6 @@ export const DashboardSnapshot: (props: {
   permalink: string;
 }) => JSX_2.Element;
 
-// @public @deprecated
-export const DashboardSnapshotComponent: (props: {
-  guid: string;
-  name: string;
-  permalink: string;
-}) => JSX_2.Element;
-
 // @public
 export const DashboardSnapshotList: (props: { guid: string }) => JSX_2.Element;
 

workspaces/newrelic/plugins/newrelic-dashboard/src/components/NewRelicDashboard/NewRelicDashboard.stories.tsx

@@ -15,7 +15,7 @@
  */
 
 import { NewRelicDashboard } from './NewRelicDashboard';
-import { MockStorageApi, TestApiProvider } from '@backstage/test-utils';
+import { mockApis, TestApiProvider } from '@backstage/test-utils';
 import { EntityProvider } from '@backstage/plugin-catalog-react';
 import { newRelicDashboardApiRef } from '../../api';
 import { NEWRELIC_GUID_ANNOTATION } from '../../constants';
@@ -115,7 +115,7 @@ export const NewRelicDashboardWithSnapshots = () => (
   <TestApiProvider
     apis={[
       [newRelicDashboardApiRef, newRelicApiMockFull],
-      [storageApiRef, MockStorageApi.create()],
+      [storageApiRef, mockApis.storage()],
     ]}
   >
     <EntityProvider entity={entity}>

workspaces/newrelic/plugins/newrelic-dashboard/src/index.ts

@@ -20,6 +20,5 @@ export {
   EntityNewRelicDashboardContent,
   DashboardSnapshot,
   DashboardSnapshotList,
-  DashboardSnapshotComponent,
 } from './plugin';
 export { isNewRelicDashboardAvailable } from './Router';

workspaces/newrelic/plugins/newrelic-dashboard/src/plugin.ts

@@ -92,16 +92,6 @@ export const DashboardSnapshot = newRelicDashboardPlugin.provide(
   }),
 );
 
-/**
- * Render dashboard snapshots from Newrelic in backstage. Use dashboards which have the tag `isDashboardPage: true`
- *
- * @deprecated
- * Use DashboardSnapshot export name instead
- *
- * @public
- */
-export const DashboardSnapshotComponent = DashboardSnapshot;
-
 /**
  * Render a dashboard snapshots list from Newrelic in backstage. Use dashboards which have the tag `isDashboardPage: true`
  *

workspaces/newrelic/plugins/newrelic/src/api/index.test.ts

@@ -18,7 +18,7 @@ import { NewRelicApplication, NewRelicClient } from '.';
 import { DiscoveryApi } from '@backstage/core-plugin-api';
 import { rest } from 'msw';
 import { setupServer } from 'msw/node';
-import { MockFetchApi, setupRequestMockHandlers } from '@backstage/test-utils';
+import { MockFetchApi, registerMswTestHooks } from '@backstage/test-utils';
 
 const mockedDiscoveryApi: DiscoveryApi = {
   getBaseUrl: async () => 'https://test.test',
@@ -30,7 +30,7 @@ beforeEach(() => {
 
 describe('NewRelicClient', () => {
   const server = setupServer();
-  setupRequestMockHandlers(server);
+  registerMswTestHooks(server);
 
   beforeEach(() => {
     server.resetHandlers();