enable list deprecations for workspace and resolve existing

Signed-off-by: Kurt King <[email protected]>

Author: kurtaking

workspaces/gocd/.changeset/unlucky-ants-cover.md

@@ -0,0 +1,5 @@
+---
+'@backstage-community/plugin-gocd': patch
+---
+
+Replaces global JSX with React.JSX

workspaces/gocd/bcp.json

@@ -1,4 +1,5 @@
 {
   "autoVersionBump": true,
-  "knipReports": false
+  "knipReports": false,
+  "listDeprecations": true
 }

workspaces/gocd/plugins/gocd/src/api/gocdApi.client.test.ts

@@ -14,15 +14,15 @@
  * limitations under the License.
  */
 
-import { setupRequestMockHandlers } from '@backstage/test-utils';
+import { registerMswTestHooks } from '@backstage/test-utils';
 import { GoCdClientApi } from './gocdApi.client';
 import { HttpResponse, http } from 'msw';
 import { setupServer } from 'msw/node';
 import { PipelineHistory } from './gocdApi.model';
 
 describe('GoCdClientApi', () => {
   const server = setupServer();
-  setupRequestMockHandlers(server);
+  registerMswTestHooks(server);
 
   it('makes requests through the proxy, using the provided fetch api', async () => {
     const response: PipelineHistory = {

workspaces/gocd/plugins/gocd/src/components/GoCdBuildsComponent/GoCdBuildsComponent.tsx

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { useState } from 'react';
+import { useState, JSX } from 'react';
 import { Entity } from '@backstage/catalog-model';
 import {
   useEntity,

workspaces/gocd/plugins/gocd/src/components/GoCdBuildsInsights/GoCdBuildsInsights.tsx

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+import { JSX } from 'react';
 import { groupBy, mean } from 'lodash';
 import {
   PipelineHistory,

workspaces/gocd/plugins/gocd/src/components/GoCdBuildsTable/GoCdBuildsTable.tsx

@@ -13,9 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { useState } from 'react';
-
-import * as React from 'react';
+import { useState, JSX } from 'react';
 import { Entity, getEntitySourceLocation } from '@backstage/catalog-model';
 import { useEntity } from '@backstage/plugin-catalog-react';
 import Alert from '@material-ui/lab/Alert';

workspaces/gocd/plugins/gocd/src/components/Select/Select.tsx

@@ -13,12 +13,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+import { JSX } from 'react';
 import FormControl from '@material-ui/core/FormControl';
 import InputLabel from '@material-ui/core/InputLabel';
 import MenuItem from '@material-ui/core/MenuItem';
 import Select from '@material-ui/core/Select';
 import { createStyles, makeStyles, Theme } from '@material-ui/core/styles';
-import * as React from 'react';
 
 export type Item = {
   label: string;