-
Notifications
You must be signed in to change notification settings - Fork 502
Description
📜 Description
Running yarn start inside a newly created frontend plugin fails due to missing peer dependencies such as react-dom, and react-router-dom.
👍 Expected behavior
Generated plugins should include all necessary peer dependencies so yarn start works without additional manual installation.
👎 Current Behavior
Errors include:
Module not found: Can't resolve 'react-router-dom'
Module not found: Can't resolve 'react-dom'
React 17 is now deprecated!👟 Reproduction steps
Add all required peer/dev dependencies to the generated plugin or ensure they are installed automatically as part of the scaffolding process.
📃 Provide the context for the Bug.
I am trying to make it easier for the developers in our organization to create plugins for us. As we don't want to see our own codebase bloated with different plugins from different teams we have decided to offer scaffolder templates that would give the teams a minimal repo that they could use to start their plugins.
In order to find out how such a repo should look like we decided to take a look at the CONTRIBUTING documentation and we found some issues.
👀 Have you spent some time to check if this bug has been raised before?
- I checked and didn't find similar issue
🏢 Have you read the Code of Conduct?
- I have read the Code of Conduct
Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else