Skip to content

Commit 2743967

Browse files
committed
Make unison detune a cubic rescaler in play screen
1 parent ae41768 commit 2743967

3 files changed

Lines changed: 20 additions & 8 deletions

File tree

doc/12_roadmap.md

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,15 @@ I have a lot of ideas for a '1.2' version of six sines. Not 2.0. Still compatibl
1010
- Clamp targets
1111
- LFO -> M etc... depth as an additive and attenuation target
1212

13-
## Noise Upgrades
14-
- Pink, White, Tilt (with N for tilt) **DONE**
15-
- Old BaconPaul Chip LFSR 'semi-tuned' (with N for 'sequence')
13+
## MPE Smoothing
14+
15+
Totally doable but wait until I'm with an MPE device
16+
17+
Plan approved and saved to /Users/paul/.claude/plans/witty-toasting-hoare.md. Project memory updated:
18+
new entry project_tests_harness.md records the Catch2 six-sines-test target, the two harness patterns (makePlugin vs direct class), and the rule
19+
to add new test files to tests/CMakeLists.txt explicitly. Noted your CLAUDE.md edit (line 32 now acknowledges tests).
1620

1721
## Smaller Things from the crew
18-
- Can we smooth MPE pitch bend with a lagger? (Or do we)
19-
- Unison retuning slider could cubic rescale
20-
- Mod target sliders scale matches display rescaling based on target (could be tricky)
2122
- Now we have DES move MPE to the instance
2223
- if you load a stream which has it from the clap edge set the instance to that
2324
- if you load a patch from an sxsnp ignore the patch setting
@@ -29,6 +30,10 @@ I have a lot of ideas for a '1.2' version of six sines. Not 2.0. Still compatibl
2930
- windows ui open isn't right
3031
- jack on linux
3132

33+
## Noise Upgrades **DONE**
34+
- Pink, White, Tilt (with N for tilt) **DONE**
35+
- Old BaconPaul Chip LFSR 'semi-tuned' (with N for 'sequence') **DONE**
36+
3237
## MPE Pitch Bend **DONE**
3338

3439
- basically in mpe mode interpolate between keys for mts tuning in voice.cpp
@@ -88,6 +93,12 @@ Want modes - like segmented float,
8893

8994
# 1.3 Roadmap (pushed from 1.2)
9095

96+
Write these up as issues when done
97+
98+
## Small
99+
- Mod target sliders scale matches display rescaling based on target (defer - too tricky)
100+
101+
91102
## Granular FM
92103

93104
- that crazy idea kisney and i chatted about

src/ui/playmode-sub-panel.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ PlayModeSubPanel::PlayModeSubPanel(SixSinesEditor &e) : HasEditor(e)
120120
uniRPhase->setLabel("Rand Phase");
121121
addAndMakeVisible(*uniRPhase);
122122

123-
createComponent(editor, *this, on.unisonSpread, uniSpread, uniSpreadD);
123+
createRescaledComponent(editor, *this, on.unisonSpread, uniSpread, uniSpreadD);
124124
addAndMakeVisible(*uniSpread);
125125
uniSpreadG = std::make_unique<jcmp::GlyphPainter>(jcmp::GlyphPainter::TUNING);
126126
addAndMakeVisible(*uniSpreadG);

src/ui/playmode-sub-panel.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ struct PlayModeSubPanel : juce::Component, HasEditor
7272
std::unique_ptr<PatchDiscrete> uniRPhaseDD;
7373

7474
std::unique_ptr<jcmp::HSliderFilled> uniSpread, uniPan;
75-
std::unique_ptr<PatchContinuous> uniSpreadD, uniPanD;
75+
std::unique_ptr<PatchContinuous::cubic_t> uniSpreadD;
76+
std::unique_ptr<PatchContinuous> uniPanD;
7677
std::unique_ptr<jcmp::GlyphPainter> uniSpreadG, uniPanG;
7778

7879
std::unique_ptr<jcmp::ToggleButton> mpeActiveButton;

0 commit comments

Comments
 (0)