Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated test of the docker build #2816

Open
paulmelnikow opened this issue Jan 20, 2019 · 2 comments
Open

Automated test of the docker build #2816

paulmelnikow opened this issue Jan 20, 2019 · 2 comments
Labels
developer-experience Dev tooling, test framework, and CI self-hosting Discussion, problems, features, and documentation related to self-hosting Shields

Comments

@paulmelnikow
Copy link
Member

@chris48s wrote at #2814 (comment):

I think we should be able to just call docker run inside Circle CI. That would at least give a us a smoke test that it doesn't throw an error.

A couple references:

I think ideally what we want is three things:

  1. Check that container builds
  2. Check that container runs
  3. Fetch a badge from the server and ensure it works

We also need a way to shut down the container after 2 or 3 is finished.

@paulmelnikow paulmelnikow added developer-experience Dev tooling, test framework, and CI self-hosting Discussion, problems, features, and documentation related to self-hosting Shields labels Jan 20, 2019
@calebcartwright
Copy link
Member

calebcartwright commented Feb 10, 2019

On the third step, what would a test look like? Could we simply use the badge-cli script (https://github.com/badges/shields/blob/master/scripts/badge-cli.js) or should we set up a new mocha test suite?

Also I'm guessing we'd want to include this both on PR builds as well as the daily test runs. Any disagreements there?

@paulmelnikow
Copy link
Member Author

I mentioned at #3558 (comment) that a Docker Hub's automated tests might be a decent and simple way of accomplishing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI self-hosting Discussion, problems, features, and documentation related to self-hosting Shields
Projects
None yet
Development

No branches or pull requests

2 participants