Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Self-Hosted] Allow endpoint to use "http" protocol #8622

Closed
jorioux opened this issue Nov 11, 2022 · 1 comment
Closed

[Self-Hosted] Allow endpoint to use "http" protocol #8622

jorioux opened this issue Nov 11, 2022 · 1 comment
Labels
self-hosting Discussion, problems, features, and documentation related to self-hosting Shields

Comments

@jorioux
Copy link

jorioux commented Nov 11, 2022

📋 Description

I'm running shields.io self-hosted on kubernetes.

I have a second service that returns JSON to generate custom badges in this format:

{
  "schemaVersion": 1,
  "label": "hello",
  "message": "sweet world",
  "color": "orange"
}

Right now, my badges URL looks like this:

https://shields.domain.com/endpoint?url=https://custombadges.domain.com/service1/health

Since shields and my custom badges service are running on Kubernetes, Shields should be able to call an endpoint on the same namespace (using Kubernetes internal DNS) in http like this:

https://shields.domain.com/endpoint?url=http://custombadges/service1/health

Proposition

Could you add the option to not force the https protocol when calling an endpoint?

@jorioux jorioux changed the title Allow endpoint to use "http" protocol [Self-Hosted] Allow endpoint to use "http" protocol Nov 11, 2022
@chris48s chris48s added the self-hosting Discussion, problems, features, and documentation related to self-hosting Shields label Nov 13, 2022
@calebcartwright
Copy link
Member

Thanks but going to close as a duplicate of #2891 to avoid bifurcation

@calebcartwright calebcartwright closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self-hosting Discussion, problems, features, and documentation related to self-hosting Shields
Projects
None yet
Development

No branches or pull requests

3 participants