From 6866954b089acf57dc7266b664c95d25a440c0f5 Mon Sep 17 00:00:00 2001 From: jNullj <15849761+jNullj@users.noreply.github.com> Date: Sun, 4 May 2025 23:00:44 +0300 Subject: [PATCH 1/3] fix: update message for Locked version of VCS dependency badge to use version validation --- services/github/github-pipenv.tester.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/services/github/github-pipenv.tester.js b/services/github/github-pipenv.tester.js index 6ae2de5f2a148..c23e59e3f8fd7 100644 --- a/services/github/github-pipenv.tester.js +++ b/services/github/github-pipenv.tester.js @@ -1,7 +1,6 @@ import Joi from 'joi' import { ServiceTester } from '../tester.js' import { - isCommitHash, isVPlusDottedVersionAtLeastOne, isVPlusDottedVersionNClausesWithOptionalSuffix, } from '../test-validators.js' @@ -85,5 +84,5 @@ t.create('Locked version of VCS dependency') .get('/locked/dependency-version/pypa/pipenv/dev/pypiserver.json') .expectBadge({ label: 'pypiserver', - message: isCommitHash, + message: isVPlusDottedVersionNClausesWithOptionalSuffix, }) From f4b0d36661f6540b37ac36bdfcee32c0c770765c Mon Sep 17 00:00:00 2001 From: jNullj <15849761+jNullj@users.noreply.github.com> Date: Mon, 5 May 2025 22:39:52 +0300 Subject: [PATCH 2/3] revert to VCS deps picked `https://github.com/ykdojo/editdojo/` as it seems to be real world example of somewhat popular repo with a VCS deps that is not often updated --- services/github/github-pipenv.tester.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/services/github/github-pipenv.tester.js b/services/github/github-pipenv.tester.js index c23e59e3f8fd7..dd879374d1b6d 100644 --- a/services/github/github-pipenv.tester.js +++ b/services/github/github-pipenv.tester.js @@ -1,6 +1,7 @@ import Joi from 'joi' import { ServiceTester } from '../tester.js' import { + isCommitHash, isVPlusDottedVersionAtLeastOne, isVPlusDottedVersionNClausesWithOptionalSuffix, } from '../test-validators.js' @@ -81,8 +82,8 @@ t.create('Locked version of unknown dependency') }) t.create('Locked version of VCS dependency') - .get('/locked/dependency-version/pypa/pipenv/dev/pypiserver.json') + .get('/locked/dependency-version/ykdojo/editdojo/tweepy.json') .expectBadge({ label: 'pypiserver', - message: isVPlusDottedVersionNClausesWithOptionalSuffix, + message: isCommitHash, }) From 60d552034c8e3116c56b1df7bbbefed6c281af5d Mon Sep 17 00:00:00 2001 From: jNullj <15849761+jNullj@users.noreply.github.com> Date: Mon, 5 May 2025 22:46:22 +0300 Subject: [PATCH 3/3] fix label fix from prev commit --- services/github/github-pipenv.tester.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/github/github-pipenv.tester.js b/services/github/github-pipenv.tester.js index dd879374d1b6d..bb291e8615aef 100644 --- a/services/github/github-pipenv.tester.js +++ b/services/github/github-pipenv.tester.js @@ -84,6 +84,6 @@ t.create('Locked version of unknown dependency') t.create('Locked version of VCS dependency') .get('/locked/dependency-version/ykdojo/editdojo/tweepy.json') .expectBadge({ - label: 'pypiserver', + label: 'tweepy', message: isCommitHash, })