Skip to content

Commit fd12de6

Browse files
ruanLNJefferson Stachelski
authored and
Jefferson Stachelski
committed
cleaning up code
1 parent 837dfff commit fd12de6

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

Diff for: gpg_group_chat/client/client.py

+4-14
Original file line numberDiff line numberDiff line change
@@ -9,27 +9,18 @@ def __init__(self):
99
self._socket = None
1010
self._connected = False
1111
self._nickname = 'anonymous'
12-
self._key = 'no-key'
1312

14-
def start(self, server_ip = None, server_port = None, nickname = None):
13+
def start(self, server_ip, server_port, nickname = None):
1514
if nickname != None:
1615
self._nickname = nickname
17-
if server_ip == None:
18-
print('no server addr')
19-
return
20-
self._key = 'no-key'
2116
print('Hello friend ' + self._nickname)
2217
dest = (server_ip, server_port)
2318
try:
2419
self._socket = socket.create_connection(dest)
2520
except:
2621
print('error opening socket')
2722
return;
28-
success = self.__start_protocol()
29-
if(success):
30-
self.__handle_messages()
31-
else:
32-
print('error to stabilish connection')
23+
self.__handle_messages()
3324

3425
def __start_protocol(self):
3526
msg = 'hello, i am ' + self._nickname + ',' + self._key
@@ -49,10 +40,9 @@ def __start_protocol(self):
4940
return True
5041

5142
def __handle_messages(self):
52-
#exemple found here: http://www.bogotobogo.com/python/python_network_programming_tcp_server_client_chat_server_chat_client_select.php
5343
socket_list = [sys.stdin, self._socket]
5444
self.__prompt()
55-
while 1:
45+
while True:
5646
ready_to_read,ready_to_write,in_error = select.select(socket_list , [], [])
5747
for sock in ready_to_read:
5848
if sock == self._socket:
@@ -70,7 +60,6 @@ def __handle_messages(self):
7060
# user entered a message
7161
msg = sys.stdin.readline()
7262
msg = '['+self._nickname+'] ' + msg
73-
msg = self.__gpg_encrypt(msg)
7463
self._socket.send(msg.encode('utf-8'))
7564
self.__prompt()
7665

@@ -81,3 +70,4 @@ def __prompt():
8170

8271
def __gpg_encrypt(self,msg):
8372
return msg
73+
sys.stdout.flush()

0 commit comments

Comments
 (0)